Repository navigation
Keep a union benevolent when its members absorbed benevolent members - #6960
Merged
Merged
Conversation
TypeCombinator::union() kept the result benevolent only when every member described exactly like a benevolent input member. Merging (int<min, -1>|int<1, max>|string) with 0 produces int, which matches none of them, so the union lost its benevolence - e.g. an array key after a switch narrowed it with loose comparisons on PHP 7. Amp-Thread-ID: https://ampcode.com/threads/T-01a1ad8d-7160-7699-b079-02097b61a80b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeCombinator::union()kept the result benevolent only when every result member described exactly like a benevolent input member. Merging(int<min, -1>|int<1, max>|string)with0producesint, which matches none of them, so the union became a plainint|string.Since the loose-comparison narrowing (9d55d96), the PHP 7 false branch of
$key == 'shipping'removes0from an array key, and merging the switch branches back hit this. The same happened on any PHP version after e.g.if ($key !== 0) {}.A result member that is a supertype of a benevolent member now keeps the union benevolent; a member that absorbed nothing benevolent (e.g.
float) still makes it plain. The nativeTypeCombinatormirror in turbo-ext gets the same change.array_rand()on an array with explicit int keys and a$mixedkey now returns(int|string)as well, for the same reason.Closes phpstan/phpstan#15667