Repository navigation
Cache Composer packages in the musl differential tests - #6942
Open
SanderMuller wants to merge 1 commit into
Open
SanderMuller wants to merge 1 commit into
SanderMuller wants to merge 1 commit into
Conversation
The musl differential test job installs Composer packages inside an Alpine container with an empty cache. Each of its 20 legs downloads every package from GitHub, and one failed download fails the leg. A leg failed on an HTTP 504 for symfony/polyfill-intl-normalizer, after Composer retried the download. The job now restores a Composer cache, keyed on composer.lock, the same way it restores the PHP build. turbo-compile-core-musl-arm64 keeps its uncached install, because the core it builds ships. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # tests ship nothing, so unlike turbo-compile-core-musl-arm64 they | ||
| # can trust a cache entry. | ||
| - name: "Restore the Composer cache" | ||
| uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The musl differential test job runs
composer installin an Alpine container with an empty cache. So each of its 20 legs downloads every package from GitHub, and one failed download fails the leg. This leg on #6932 failed when GitHub returned HTTP 504 forsymfony/polyfill-intl-normalizer, after Composer retried the download.The job now restores a Composer cache through
actions/cache, keyed oncomposer.lock, next to the PHP build cache it already restores.COMPOSER_HOMEstays a temporary directory, and the verified Composer download does not change.I did not add the cache to
turbo-compile-core-musl-arm64. That job runscomposer installfor the PGO training of the core that ships. The comment on theturbo-originsjob excludesactions/cachefrom that path. Many packages incomposer.lockhave an emptyshasum, so Composer cannot check a cached zip.zizmor reports a
cache-poisoningfinding for the new step, the same finding it reports for the threealpine-php-cachesteps.🤖 Generated with Claude Code