Repository navigation
Narrow intdiv() return type from integer ranges - #6925
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
intdiv()always returnedint, because the only extension for it described what it throws. This addsIntdivFunctionReturnTypeExtension, which derives the result range from the integer ranges of both arguments.intdiv()is evaluated at the four corners. Truncated division is monotonic in both operands while the divisor keeps one sign, so the corners give the exact bounds. Unbounded ends are handled as ±INF.intdiv(3|int<10, 12>, 2)is1|int<5, 6>./logic inInitializerExprTypeResolveris not reused: it rounds bounds inwards (int<1, 5> / 2→int<1, 2>|float), whileintdiv()truncates towards zero (int<0, 2>).Examples:
intdiv(int<0, max>, int<1, max>)→int<0, max>,intdiv(int<-7, -1>, 2)→int<-3, 0>,intdiv(7, 2)→3.Verified against brute-force
intdiv()over 5,041 range pairs: every result is contained, and for bounded ranges the bounds are exact.Closes phpstan/phpstan#15282
Closes phpstan/phpstan#15347