Repository navigation
Do not suggest #[RequiresPhp] on methods that already have it - #6922
Merged
Merged
Conversation
ondrejmirtes
force-pushed
the
skip-tests-requires-php-existing-attribute
branch
3 times, most recently
from
November 3, 2026 10:22
8737614 to
133b53d
Compare
…eady have #[RequiresPhp] The attribute is not repeatable, so suggesting another one is wrong. Amp-Thread-ID: https://ampcode.com/threads/T-01a1a0d3-ad3e-7141-bcfe-124dc73d21ee
ondrejmirtes
force-pushed
the
skip-tests-requires-php-existing-attribute
branch
from
November 3, 2026 10:23
133b53d to
d37535b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[RequiresPhp]is not repeatable, soSkipTestsWithRequiresPhpAttributeRulemust not suggest adding it to a test method that already has one. This removes the@phpstan-ignore phpstan.skipTestsRequiresPhpcomments that worked around it.In
PropertiesInInterfaceRuleTest::testPhpVersionNarrowedScope, which had no attribute, the rule's suggestion is applied instead.