Repository navigation
Conversation
staabm
force-pushed
the
narrowvers
branch
4 times, most recently
from
February 10, 2026 09:02
a14ab38 to
4f03cb8
Compare
staabm
commented
Feb 10, 2026
| if ($integerVersionRange !== null) { | ||
| $narrowedVersion = TypeCombinator::intersect($scope->getPhpVersion()->getType(), $integerVersionRange); | ||
| return $this->typeSpecifier->create( | ||
| new ConstFetch(new Name('\\PHP_VERSION_ID')), |
Contributor
Author
There was a problem hiding this comment.
I feel I am hitting a bug here, as depending on how I name the constant here
PHP_VERSION_ID vs. \\PHP_VERSION_ID the inference does not work as expected
(and it seems it depends on whether the code beeing analyzed is namespaced or not)
ondrejmirtes
force-pushed
the
narrowvers
branch
from
November 1, 2026 12:02
4f03cb8 to
e4fc441
Compare
…gument Bound the e2e expectations by the maximum supported PHP version, like lower() already does. Amp-Thread-ID: https://ampcode.com/threads/T-01a196f7-f93b-768c-b77e-ed3b410c5bf7
ondrejmirtes
force-pushed
the
narrowvers
branch
from
November 1, 2026 12:08
e4fc441 to
b635d37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#13904