Repository navigation
Printer: keep Doctrine annotation name and missing parentheses - #327
Merged
ondrejmirtes merged 1 commit intoOct 26, 2026
Merged
Conversation
A Doctrine annotation without arguments, e.g. @\Foo\Id, has no tokens. The format-preserving printer reprinted the tag and added "()", also when nothing changed. The tokens of DoctrineTagValueNode do not contain the annotation name. When the printer reprinted only the value, the name was printed twice, e.g. @route@Route("/path") other description. Amp-Thread-ID: https://ampcode.com/threads/T-01a17930-0285-73c5-a957-4325c77aa1b2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 errors in
Printer::printFormatPreserving()for Doctrine annotations.An annotation without arguments, e.g.
@\Foo\Id, has no tokens. The printer reprinted the tag and added(), also when nothing changed:Now, if a sub-node has no tokens and prints the same as the original sub-node, the printer keeps it.
The tokens of
DoctrineTagValueNodedo not contain the annotation name. The parentPhpDocTagNodeprints the name. When the printer reprinted only the value, the name was printed twice:Now the printer prints the value without the name. If the original annotation had no parentheses and has no arguments, the printer does not add them.
Found when I examined how Rector can replace its own docblock printer with this printer.