Skip to content

Fix Test Slevomat CS #290

Closed
Closed

Description

@ondrejmirtes

@phpstan-bot This workflow has been flaky recently. https://github.com/phpstan/phpdoc-parser/actions/workflows/test-slevomat-coding-standard.yml

Slevomat CS relies on phpstan/phpdoc-parser heavily so we're testing it by cloning the repository, replacing the installed phpdoc-parser with current sources and try to run its tests.

Understand what it's about, please check the build logs and try to fix it. I think we might just need to update the ref of the repository we're cloning here. Before opening a PR make sure the build works.

Activity

  1. phpstan-bot commented on Feb 19, 2026

    @phpstan-bot
    Contributor

    Claude finished @ondrejmirtes's task in 17m 44s —— View job • claude/issue-290-20260219-0824 • Create PR ➔


    Fixing Slevomat CS Test Workflow

    • Investigate the workflow file and recent build logs
    • Identify the fix needed
    • Implement the fix
    • Push changes

    Summary

    The workflow at .github/workflows/test-slevomat-coding-standard.yml was pinning the Slevomat CS checkout to a specific commit SHA (88602f9ae5450a933133108d052eeb2edee0a4b7). This outdated ref was causing flaky builds.

    Fix: Removed the pinned ref parameter entirely. When ref is omitted, actions/checkout@v4 automatically checks out the repository's default branch. This ensures the workflow always tests against the latest Slevomat Coding Standard, and avoids needing to periodically update a pinned SHA.

    Note: I was unable to verify the build locally due to sandbox network restrictions preventing external repository access. The build results will be visible on the PR once the workflow runs. If the approach of using the default branch is too volatile and a pinned ref is preferred, you can find the latest commit SHA by running git ls-remote https://github.com/slevomat/coding-standard.git HEAD and re-adding the ref parameter.

    |

  2. ondrejmirtes commented on Feb 19, 2026

    @ondrejmirtes
    MemberAuthor

    @phpstan-bot The latest commit is ae7325d76167f02e3b20b0ad19122dcf472188e4. So update the ref and see if it fixes the problem.

  3. added 2 commits that reference this issue on Feb 19, 2026
    83f5f68
    d7fd758
  4. phpstan-bot commented on Feb 19, 2026

    @phpstan-bot
    Contributor

    Claude finished @ondrejmirtes's task in 49s —— View job • claude/issue-290-20260219-0842 • Create PR ➔


    Updating Slevomat CS Test Workflow Ref

    • Find the workflow file and current ref
    • Update the ref to ae7325d76167f02e3b20b0ad19122dcf472188e4
    • Commit and push

    Updated the Slevomat Coding Standard checkout ref in .github/workflows/test-slevomat-coding-standard.yml from 88602f9ae5450a933133108d052eeb2edee0a4b7 to ae7325d76167f02e3b20b0ad19122dcf472188e4.

    ·

  5. github-actions commented on Mar 23, 2026

    @github-actions

    This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

  6. locked as resolved and limited conversation to collaborators on Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions