Repository navigation
Add a Knowledge Base feature check and introduction screenshots - #72
Merged
Merged
Conversation
check_knowledgebase: the ACP adds a category and refuses the form without its token and a move link without its hash; a member submits an article that other members cannot read, nor open its approve page, until a moderator assigns it to a team, marks it reviewed and approves it; then members read it and the Knowledge Base search finds it. A board with no KB team uses the Administrators group as one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
seed-forum's Knowledge Base fixtures add required custom fields, so the check's article was refused on seeded boards. It now gives each required field its first enabled value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
13-index-introduction switches on the introduction above the index, with the default text the extension stores on install, and switches it off again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The extension's gallery already has shots 13 to 16 from earlier sets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A feature check and two more screenshots for phpbbmodders/knowledgebase.
Feature check (
check_knowledgebaseinfeature_checks.py)A board with no Knowledge Base team uses the Administrators group as one. Required custom fields, which seed-forum's fixtures add, get their first enabled value.
Screenshots (
shots_knowledgebaseinscreenshots.py)17-index-introductionand18-acp-introductionswitch on the introduction above the index and show it on the index and in the ACP configuration, then switch it off again. The numbering starts at 17 because the extension's gallery already has 13 to 16. The README's Knowledge Base paragraph says so.Testing
Claude ran:
setup-board.shboard: 10 of 10 on the extension's new branch. Against the extension'smain, exactly the three refusal checks fail, since that code has the bugs they look for.--seed-boardon fresh seed-forum boards for phpBB 3.3.19 and 4.0.0-a3-dev on SQLite, MySQL 8.4, MariaDB, PostgreSQL 16 and MSSQL: 14 of 14 on each, with the disable, purge and enable round trip.screenshots.pyfor the extension: 14 saved, 0 failed.Goes with phpbbmodders/knowledgebase#16, which fixes what the refusal checks catch.
Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code