Fix MSVC shift warnings in IR vector bounds checks - #23993
Closed
realFlowControl wants to merge 1 commit into
Closed
realFlowControl wants to merge 1 commit into
realFlowControl wants to merge 1 commit into
Conversation
Make the conversion of IR_VECTOR_LENGTH to int64_t explicit in the REPLACE and EXTRACT folding rules. The vector length fits in 32 bits, but MSVC warns when its shifted value is implicitly widened for comparison (C4334), breaking builds with /WX. Keep the fix as a bundled-source patch so the IR import remains reproducible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the failing Windows CI by making the conversion of
IR_VECTOR_LENGTHtoint64_texplicit.Likely came with #23861