Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a non-blocking listener,
stream_socket_accept()with no client waiting went down the same path as a real failure and raisedAcceptFailed("Connection timed out"). That makes the usual "accept until empty" drain loop throw inStreamErrorMode::Exception, and the only way to tell it apart from something like fd exhaustion was the message text.The TCP and TLS transports now treat a poll timeout or
EAGAINon a non-blocking listener as "nothing to accept" and return success without a client, sostream_socket_accept()returnsfalsewithout reporting an error. Blocking listeners still report the timeout as before.PHP_TIMEOUT_ERROR_VALUEmoved fromnetwork.ctophp_network.hso the transports can check for it.Fixes #23879