Conversation
marc-mabe
force-pushed
the
fix/GH-23811
branch
from
September 21, 2026 08:59
5f80ef5 to
286faa0
Compare
zend_object_alloc() zeroes the object, so cached_resize started at 0, which spl_fixedarray_resize() reads as "resize in progress" and returns early. setSize() therefore did nothing on subclasses whose constructor does not call parent::__construct(). Initialise the struct on object creation.
setSize(0) clears the array before destroying its elements, so it looks unconstructed to userland. __construct(), __wakeup() and __unserialize() then re-initialised it, and the in-progress clear discarded the buffer they had installed. cb3dc62 fixed the same leak for a re-entrant setSize() by testing the resize sentinel first; apply that test to the other three entry points.
marc-mabe
force-pushed
the
fix/GH-23811
branch
from
September 21, 2026 09:02
286faa0 to
a510a44
Compare
Contributor
Author
|
I accidentally rebased from master - fixed that - sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23811