Conversation
Under ERRMODE_EXCEPTION, really_register_bound_param() raised the implementation error for an unknown column name and then registered the binding anyway, so repeated failing bindColumn() calls with distinct names grew bound_columns without bound. Abort registration once an exception is pending; bindValue() and bindParam() take the is_param path and are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under ERRMODE_EXCEPTION, really_register_bound_param() raises the implementation error for an unknown column name and then registers the binding anyway, so repeated failing bindColumn() calls with distinct names grow bound_columns without bound, about 33 MB over 200k calls. Registration now aborts once an exception is pending. bindValue() and bindParam() take the is_param path, which skips this mapping block, so they are unaffected.