ext/standard: Do not double the slash when resolving relative redirects - #23532
Open
iliaal wants to merge 1 commit into
Open
ext/standard: Do not double the slash when resolving relative redirects#23532iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
resource->path always ends in a slash once the relative-Location code truncates it after the last one (s[1] = '\0'), so the "%s/%s" format built targets like /a//xy for "Location: xy" from /a/b. Use "%s%s" and drop the root-path special case it makes redundant.
Member
|
Is this the issue I fixed unintentionally in #22875 ? As if so might be better to just merge the refactoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to GH-23521. resource->path always ends in a slash by the time the relative Location is appended (s[1] = '\0' truncates it after the last one), so the "%s/%s" format doubles the separator: Location: xy from http://host/a/b redirects to /a//xy instead of /a/xy. "%s%s" fixes that and makes the root-path special case redundant. Single-character locations keep resolving against the host root, as pinned on the stable branches.