Repository navigation
fix: set REQUEST_URI when booting workers - #2701
Merged
Merged
Conversation
Since the php_server unification, the context used to boot workers no longer sets requestURI, so $_SERVER['REQUEST_URI'] is empty during boot. Nextcloud compares it to its web root and exits before reaching frankenphp_handle_request(), which makes startup fail. Fixes #2697
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2697, a regression in 1.13.0.
#2499 replaced the dummy context used to boot workers with
newWorkerDummyContext(), which never setsrequestURI. During boot,$_SERVER['REQUEST_URI']is now""instead of the script name, as it was in 1.12.7.Nextcloud's
OC::initPaths()comparesREQUEST_URIwith its web root, which is also""for an instance at the vhost root, then redirects and callsexit(). The worker never reachesfrankenphp_handle_request()and startup fails with "too many consecutive failures".This sets
requestURIthe same wayNewRequestWithContext()does. The new test fails onmainwith the reporter's error and passes with the fix.