Skip to content

Remove skeleton comments#309

Open
NickSdot wants to merge 2 commits into
php:masterfrom
NickSdot:remove-skeleton-comments
Open

Remove skeleton comments#309
NickSdot wants to merge 2 commits into
php:masterfrom
NickSdot:remove-skeleton-comments

Conversation

@NickSdot

@NickSdot NickSdot commented Jun 26, 2026

Copy link
Copy Markdown

In php/doc-en#5630 we decided to remove these comments, and mention PER instead of PECL; this PR aligns the doc-base skeletons to that decision.

Additionally
I added todo markers to PECL references in the skeleton directory (second commit). Since PECL is deprecated in favour of PIE, we should think about what to do with these - I'd appreciate your input to that! Marked as draft for now -- before the merge the second comments should either be dropped, or a follow up commit be made for whatever you imagine to happen with the PECL mentions.

Comment thread skeletons/configure.xml Outdated
Comment thread skeletons/method.xml Outdated
@NickSdot NickSdot marked this pull request as draft June 26, 2026 10:08
Comment thread skeletons/versions.xml Outdated
@kamil-tekiela

Copy link
Copy Markdown
Member

If we decide that we no longer allow PECL in the manual then the skeletons can be updated. I don't know who is using the skeletons and for what, but as of now, PECL extensions are still documented in the PHP manual. Either way it's a distinct change from removal of the editor fence comments.

@NickSdot

NickSdot commented Jun 26, 2026

Copy link
Copy Markdown
Author

> but as of now, PECL extensions are still documented

But no new docs added. So why would the skeleton/templates keep it?

Edit:

If we decide that we no longer allow PECL in the manual then the skeletons can be updated. I don't know who is using the skeletons and for what, but as of now, PECL extensions are still documented in the PHP manual. Either way it's a distinct change from removal of the editor fence comments.

You are right, having this discussion mixed in here doesn't make sense. I opened #310

@NickSdot NickSdot force-pushed the remove-skeleton-comments branch from 38f08a0 to 9b972d4 Compare June 26, 2026 10:26
@NickSdot NickSdot marked this pull request as ready for review June 26, 2026 10:27

@kamil-tekiela kamil-tekiela left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. But I don't know know if we should have these skeletons.

@NickSdot

Copy link
Copy Markdown
Author

Ok. But I don't know know if we should have these skeletons.

Personally I found them helpful to get an idea for what is available without checking individual docs pages -- as in having a full overview at a glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants