Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider features planned for 4.7.0. One commit per issue, plus real-page snapshots and docs. All existing fixtures give the same results; the new behavior is covered by offline tests in
tests/ProviderFeaturesTest.phpandtests/ChineseProvidersTest.php, and by two new real-page snapshots (Tencent Video and a public Google Drive video).Resolved
maxresdefault.jpg(Fixes Use maxresdefault instead of hqdefault for YouTube embeds #535):$info->imageusesmaxresdefault.jpgwhen the video page links it inog:image(YouTube only does it when the video has one), and keeps the oEmbedhqdefault.jpgotherwise. Only an image of the same video id is accepted.end=and also losest=/start=because Embed asks it for the canonical URL. Both are now added to the player URL from the requested URL, in seconds or in the1m30sformat. Checked live:watch?v=ID&t=10&end=20givesembed/ID?feature=oembed&start=10&end=20...._295x166), which makes Vimeo's CDN serve the full size image (checked: 295x166 becomes 1280x720 or 1920x1440). The resized one stays available ingetOEmbed()->url('thumbnail_url').drive.google.com/file/d/<id>/(view|edit|preview),/file/u/<n>/d/<id>/...and/open?id=<id>. It builds the same/previewiframe as Drive's "Embed item" option. Files that answer with an error status (private or deleted, like the existing0B2rwN8...snapshot, which answers 401) get no code, so that snapshot is unchanged.Partially covered
application-nameandapple-mobile-web-app-titlemetas before falling back to the domain, and the fallback skipswww(eportugal.gov.ptnow redirects towww.gov.pt, which gave "Www"; it now gives "Gov"). The README explains how to replace the detector to getnullinstead of the fallback, as asked in the thread. A site that declares no name at all still gets the capitalized domain, so this does not close the issue.v.qq.com/txp/iframe/player.html?vid=<vid>player fromv.qq.com/x/cover/<cid>/<vid>.html,v.qq.com/x/page/<vid>.htmlandv.qq.com/x/cover/<cid>.html?vid=<vid>URLs (cover URLs without a vid point to a whole series and get no code). The page is rendered with JavaScript, so title and image are usually missing. Status of the rest of the list, checked live on 2026-11-20:tvidneeded by its player is not in the HTML, so there is no player that can be built from the URL. Left out.n600854351) is a page id, not the playervid, so theiplay.htmlplayer cannot be built from the URL. Generic extraction already gets title, description and image.<video>tag fromog:video.cloud_ip_bl) and now belongs to Youku.Left out
.jsonAPI), except for allowlisted link preview crawlers, and theshare.redd.itpreview image is a generic placeholder for other clients. Theold.reddit.comrewrite proposed in the issue could not be verified from a residential connection, so it is not included.$info->code->ratioplus CSS (aspect-ratioor the padding technique) already covers it, as answered in the thread.Tests
PHPUnit passes on PHP 7.4, 8.1, 8.2, 8.3, 8.4 and 8.5 (331 tests). PHPStan reports no errors. PHP 8.0 is covered by CI.