Configure a code for Authenticators to indicate AUTH_USER_NOT_FOUND - #68
Open
carrvo wants to merge 9 commits into
Open
Configure a code for Authenticators to indicate AUTH_USER_NOT_FOUND#68carrvo wants to merge 9 commits into
carrvo wants to merge 9 commits into
Conversation
Original commit from https://github.com/mkj return AUTH_USER_NOT_FOUND
keep the existing behaviour (no special return codes) as the default, but allow the user to define a particular return code (new directive) to mean the user does not exist.
bimimicah
requested changes
Mar 28, 2026
Collaborator
There was a problem hiding this comment.
Looks pretty good! Just needs a few comment/naming tweaks for clarity.
Side note: I used the new GitHub review experience to submit the comments, and I see they are all jumbled up here. 😓 They might make more sense if you use the 'Files Changed' tab at the top to see them in order in the file 😅
Collaborator
|
@carrvo, I sent you an e-mail at the address in your profile. |
Signed-off-by: carrvo <carrvo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #40
Add AuthnUserNotFoundCode directive
Keeps the existing behaviour (no special return codes) as the default, but allow the user to define a particular return code (new directive) to mean the user does not exist.