Skip to content

Use project yamllint rules for changelog entry line lengths - #1176

Draft
phlax with Copilot wants to merge 3 commits into
py-envoy.code.check-changelogfrom
copilot/py-envoycheck-changelog-entry-length
Draft

phlax with Copilot wants to merge 3 commits into
py-envoy.code.check-changelogfrom
copilot/py-envoycheck-changelog-entry-length

Conversation

Copilot AI commented Oct 12, 2026 •

Copy link
Copy Markdown

The hard-coded 136-character limit and whitespace heuristic diverge from yamllint’s configurable line-length rules. This change delegates validation to yamllint using the four-space indentation applied during YAML rendering.

  • Validation
    • Remove the manual limit; report only line-length diagnostics with entry paths and line numbers.
  • Configuration
    • Pass the project’s .yamllint path into the checker.
    • Cache configuration loading; support an explicit config and fall back to extends: default.
  • Regression coverage
    • Cover indentation, multiple errors, non-breakable words/mappings, configuration loading, and unrelated-rule filtering.
    • Preserve real yamllint behavior: single-token references pass, but the supplied labeled :ref: example still produces a diagnostic because it contains a space.

dio and others added 2 commits October 12, 2026 10:14
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Co-authored-by: phlax <454682+phlax@users.noreply.github.com>
Copilot AI changed the title [WIP] Add line length checker for changelog entries Use project yamllint rules for changelog entry line lengths Oct 12, 2026
Copilot AI requested a review from phlax October 12, 2026 09:48
@phlax
phlax force-pushed the py-envoy.code.check-changelog branch 2 times, most recently from 5206a30 to b01463f Compare October 12, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants