Skip to content

Exclude unused ph-masterdata from phase4-lib - #391

Closed
gregjotau wants to merge 1 commit into
phax:masterfrom
gregjotau:contrib/exclude-unused-ph-masterdata
Closed

Exclude unused ph-masterdata from phase4-lib#391
gregjotau wants to merge 1 commit into
phax:masterfrom
gregjotau:contrib/exclude-unused-ph-masterdata

Conversation

@gregjotau

Copy link
Copy Markdown
Contributor

Fixes #390.

phase4-lib needs ph-tenancy for AbstractBusinessObject and IBusinessObject, but no Phase4 source uses the transitively supplied ph-masterdata API. This focused exclusion keeps the required tenancy dependency and avoids adding an unrelated 1,504,207-byte (1.43 MiB) JAR to every downstream runtime.

This is intentionally an exclusion on the Phase4 dependency edge rather than a change to ph-tenancy: other direct consumers of ph-tenancy may legitimately need its master-data integration.

Validation:

  • mvn -pl phase4-lib -am verify: 132 tests, 0 failures/errors
  • mvn verify: all 27 reactor modules successful
  • dependency tree no longer contains com.helger.masterdata:ph-masterdata
  • ReAI full build and real Peppol-enabled application startup verified without the JAR

@phax

phax commented Aug 12, 2026

Copy link
Copy Markdown
Owner

The changes were done by splitting submodules in ph-masterdata. Closing this one

@phax phax closed this Aug 12, 2026
@phax phax self-assigned this Aug 12, 2026
@gregjotau
gregjotau deleted the contrib/exclude-unused-ph-masterdata branch August 12, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude unused ph-masterdata transitive dependency from phase4-lib

2 participants