Exclude unused ph-masterdata from phase4-lib - #391
Closed
gregjotau wants to merge 1 commit into
Closed
Conversation
Owner
|
The changes were done by splitting submodules in ph-masterdata. Closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #390.
phase4-libneedsph-tenancyforAbstractBusinessObjectandIBusinessObject, but no Phase4 source uses the transitively suppliedph-masterdataAPI. This focused exclusion keeps the required tenancy dependency and avoids adding an unrelated 1,504,207-byte (1.43 MiB) JAR to every downstream runtime.This is intentionally an exclusion on the Phase4 dependency edge rather than a change to
ph-tenancy: other direct consumers ofph-tenancymay legitimately need its master-data integration.Validation:
mvn -pl phase4-lib -am verify: 132 tests, 0 failures/errorsmvn verify: all 27 reactor modules successfulcom.helger.masterdata:ph-masterdata