Skip to content

T19 command hint - #25

Merged
niden merged 4 commits into
masterfrom
T19-command-hint
Sep 26, 2026
Merged

niden merged 4 commits into
masterfrom
T19-command-hint

Conversation

@niden

@niden niden commented Sep 26, 2026

Copy link
Copy Markdown
Member

Hello!

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • composer test, composer cs and composer analyze all pass
  • I have created a PR for the documentation about this change, if user facing

  • Added a hint for an unknown command that a package provides. Without phalcon/migrations, crest migration:run now prints unknown command 'migration:run'; provided by phalcon/migrations. When a command with that prefix is registered, the package is installed, so a wrong name gets the plain message. Crest\Console\Registry::withProviders() takes the map of name prefix to package name; crest gives it in Crest\Commands.

Thanks

Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
@niden niden self-assigned this Sep 26, 2026
@niden niden added the enhancement New feature or request label Sep 26, 2026
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown

Code Metrics Report

master (334126b) #25 (3ebf4d2) +/-
Coverage 99.0% 99.0% +0.0%
Test Execution Time 1s 1s 0s
Details
  |                     | master (334126b) | #25 (3ebf4d2) |  +/-  |
  |---------------------|------------------|---------------|-------|
+ | Coverage            |            99.0% |         99.0% | +0.0% |
  |   Files             |               49 |            49 |     0 |
  |   Lines             |             1126 |          1137 |   +11 |
+ |   Covered           |             1115 |          1126 |   +11 |
  | Test Execution Time |               1s |            1s |    0s |

Code coverage of files in pull request scope (98.4% → 98.6%, patch 100.0%)

Files Coverage +/- Patch Coverage Status
src/Commands.php 100.0% 0.0% 100.0% modified
src/Console/Registry.php 98.2% +0.3% 100.0% modified

Reported by octocov

@niden
niden merged commit 649917a into master Sep 26, 2026
24 checks passed
@niden
niden deleted the T19-command-hint branch September 26, 2026 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant