Skip to content

CP-17601 annotation attributes - #17603

Merged
niden merged 5 commits into
5.0.xfrom
CP-17601-annotation-attributes
Sep 21, 2026
Merged

niden merged 5 commits into
5.0.xfrom
CP-17601-annotation-attributes

Conversation

@niden

@niden niden commented Sep 21, 2026

Copy link
Copy Markdown
Member

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

  • Phalcon\Annotations\ReaderInterface no longer declares the static parseDocBlock(); it stays a public static method of Phalcon\Annotations\Reader.
  • Phalcon\Mvc\Model\MetaData\Strategy\Annotations reads skipOnInsert, skipOnUpdate, allowEmptyString and defaultValue next to the skip_on_insert, skip_on_update, allow_empty_string and default it already read.

Added

  • Phalcon\Annotations\AttributesReader reads PHP attributes instead of docblocks; setReader() on the annotations adapter selects it and Phalcon\Annotations\Reader stays the default.
  • Phalcon\Annotations\Router\Route, Connect, Delete, Get, Head, Options, Patch, Post, Purge, Put, Trace, RoutePrefix and Phalcon\Annotations\Models\MetaData\Column, Identity, Primary, Source give the attribute form of the router and model metadata annotations.

Thanks

@niden
niden requested a review from Jeckerson September 21, 2026 13:25
@niden niden self-assigned this Sep 21, 2026
@niden niden added new feature request Planned Feature or New Feature Request 5.0 The issues we want to solve in the 5.0 release labels Sep 21, 2026
Assisted-by: Claude Code
@niden
niden merged commit 591d9f7 into 5.0.x Sep 21, 2026
201 of 202 checks passed
@niden
niden deleted the CP-17601-annotation-attributes branch September 21, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0 The issues we want to solve in the 5.0 release new feature request Planned Feature or New Feature Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant