Use module-const style for all enums#37
Open
sgrif wants to merge 1 commit into
Open
Conversation
I've been getting frustrated when I'm looking at the docs for a type, it's a primitive alias, and then clicking the type in rustdoc doesn't take me to something that shows me the variants, and there's no way to easily get to them from that page. I'm skittish about using rustified enums for any of these, as in C they're *just* integers, so it's possible to pass an unexpected value. If we then cast that to a Rust enum, the result will be undefined behavior. Since we don't expect to ever allow exhaustive matching anyway, using the module const form seems like a reasonable compromise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been getting frustrated when I'm looking at the docs for a type, it's a primitive alias, and then clicking the type in rustdoc doesn't take me to something that shows me the variants, and there's no way to easily get to them from that page.
I'm skittish about using rustified enums for any of these, as in C they're just integers, so it's possible to pass an unexpected value. If we then cast that to a Rust enum, the result will be undefined behavior.
Since we don't expect to ever allow exhaustive matching anyway, using the module const form seems like a reasonable compromise.