Skip to content

Diff - identity Columns & Comments #10422

Description

@RadToy

Please note that security bugs or issues should be reported to security@pgadmin.org.

Describe the bug

Whenever I do a diff between two schemas that should be identical, the process finds that the identity column definitions are sometimes different . It would be nice to be able to ignore the settings like the START value.
However, whenever there is a difference in the identity definition, the associated column comment is dragged into the mix as being different too.

Here are the definitions on the source:
status_entry_id integer NOT NULL GENERATED ALWAYS AS IDENTITY (INCREMENT 1 START 0 MINVALUE 0 MAXVALUE 2147483647 CACHE 3)
COMMENT ON COLUMN survey.application_status.status_entry_id IS 'A value to ensure that the primary key has a unique value.';

Here are the definitions on the target:
status_entry_id integer NOT NULL GENERATED ALWAYS AS IDENTITY (INCREMENT 1 START 7482970 MINVALUE 0 MAXVALUE 2147483647 CACHE 3)
COMMENT ON COLUMN survey.application_status.status_entry_id IS 'A value to ensure that the primary key has a unique value.';

The comment ddl is exactly the same between source and target, but because the START value between source and target is different, both the column and the column comment are flagged as being different.

To Reproduce

Steps to reproduce the behavior:

  1. create a table with an identity column in two different databases
  2. Add identical column comments to the identity column in both databases
  3. Change the start value of the identity in the target table
  4. Run a diff on the table
  5. You will see that the comment definition is flagged as being different between the 2 tables.

Expected behavior

A clear and concise description of what you expected to happen.

Error message

If possible, include the full, unedited text of any error messages displayed.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 11
  • pgAdmin version: 9.1.7
  • Mode: Desktop
  • Package type: [e.g. RPM, DEB, Python, Container, etc.]

Additional context

Add any other context about the problem here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions