a list can keep out of the file of its page - #31
Merged
Merged
Conversation
pfefferle
force-pushed
the
feat/private-lists
branch
from
September 24, 2026 09:29
5169d6b to
0a6e226
Compare
pfefferle
force-pushed
the
feat/private-lists
branch
7 times, most recently
from
September 24, 2026 10:55
45255e4 to
eb877bc
Compare
pfefferle
force-pushed
the
feat/private-lists
branch
from
September 24, 2026 11:03
eb877bc to
725ede3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every list on a page landed in the page's OPML and was advertised everywhere the site tells readers about its blogrolls. A list that is only of interest on that page, a few tools or references, had no way out of that.
New block setting, "Part of the page for feed readers", on by default. Switched off, the list is left out of the file of the page and out of what the site advertises elsewhere: it is not in
?opmlof its page, the page is not listed in the directory or on the front page when all of its lists are like that, and a bare?opmlon such a page loads the page instead of an empty file.What it keeps is the subscription in its own context: its own
?opml&group=<anchor>, its ownrel="blogroll"link on its page, and the download link under it, which now points at its own file.Opml::extract_groups()keeps every list, so the files of the single lists are unaffected;Opml::shared_groups()is the new basis for the page file, the page's own discovery link and the index.Index::has_blogroll()stays the cheap string search for every request, and the parsing question isIndex::has_subscribable_blogroll(), asked on save and when the directory is built.Seven tests. Checked on a real page: the page file has only the shared list,
?opml&group=toolshas the other one, the head links to both lists and to the page, and both download links point at the right file. On a page whose only list keeps to itself: only that list is advertised,?opmlloads the page, and the page is not in the directory.