sorting and paging mean one list - #30
Merged
Merged
Conversation
# Conflicts: # tests/test-render.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorting and paging were plain query parameters, so they belonged to the page, not to a list: on a page with several blogrolls, sorting one sorted all of them and paging one paged all of them. That is the open point from #2.
Every list has an anchor since 1.2.0, and
groupalready uses it for the subscription files, so the sorting and paging links use the same:?blockroll-sort=name&group=podcasts#podcasts. A list applies the sorting and the paging only when the query names it. A query that names no list still means every list, so links people shared before this keep working.Tests for both, and I checked it on a page with two lists: sorting one leaves the other alone, each pager pages its own list, and
?blockroll-sort=namewithout a group still sorts both.Fixes the remaining part of #2.