Skip to content

feat: implement issue #555 — Compliance: ruleset-drift-pr-quality-dismiss_stale_reviews_on_push #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
don-petry wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

feat: implement issue #555 — Compliance: ruleset-drift-pr-quality-dismiss_stale_reviews_on_push #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions scripts/setup-pr-quality-ruleset.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ gh auth status >/dev/null 2>&1 || { echo "Error: gh not authenticated" >&2; exit
EXISTING_ID=$(gh api "repos/$REPO/rulesets?includes_parents=false" -q ".[] | select(.name == \"$RULESET_NAME\") | .id" 2>/dev/null || echo "")

# ── Ruleset payload (used for both create and update) ─────────────────────────
# Compliance-pinned parameters (do not relax — enforced by scripts/tests/
# setup-pr-quality-ruleset.test.js and the weekly compliance audit):
# dismiss_stale_reviews_on_push: true (issue #555)
# require_last_push_approval: true (issue #539)
RULESET_PAYLOAD=$(cat <<'JSON'
{
"name": "pr-quality",
Expand Down
4 changes: 3 additions & 1 deletion scripts/tests/setup-pr-quality-ruleset.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@ const path = require('path')

// Extracts the JSON payload from the heredoc in setup-pr-quality-ruleset.sh.
// The script codifies the org-standard "pr-quality" ruleset; this test guards
// against configuration drift of the ruleset parameters (see issue #520).
// against configuration drift of the ruleset parameters. Compliance findings
// this guard protects against: #520 (initial drift guard), #539
// (require_last_push_approval), #555 (dismiss_stale_reviews_on_push).
function loadRulesetPayload() {
const scriptPath = path.join(__dirname, '..', 'setup-pr-quality-ruleset.sh')
const script = fs.readFileSync(scriptPath, 'utf8')
Expand Down
Loading