Skip to content

add getnetworkinfo RPC #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankh2054 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add getnetworkinfo RPC #217

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e546b3
add getnetworkinfo RPC
ankh2054 Oct 24, 2019
660518d
add try and except to getinfo()
ankh2054 Oct 30, 2019
16a3e92
added DepreciationWarning - use python -Wd flags to see warning
ankh2054 Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions bitcoin/rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,13 +509,21 @@ def getblockhash(self, height):
(self.__class__.__name__, ex.error['message'], ex.error['code']))

def getinfo(self):
try:
"""Return a JSON object containing various state info"""
r = self._call('getinfo')
if 'balance' in r:
r['balance'] = int(r['balance'] * COIN)
if 'paytxfee' in r:
r['paytxfee'] = int(r['paytxfee'] * COIN)
return r
except:
print("getnetworkinfo replaces getinfo on versions > 0.16.0, please use getnetworkinfo()")
Copy link
Copy Markdown
Owner

@petertodd petertodd Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should print to stderr or maybe call depreciationwarning or similar.

Copy link
Copy Markdown
Author

@ankh2054 ankh2054 Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added DepreciationWarning seems to work well. Hope that works, otherwise let me know and I can add more. I'm very new to python so excuse my ignorance on some things.

return self._call('getnetworkinfo')

def getnetworkinfo(self):
"""Return a JSON object containing various state info"""
r = self._call('getinfo')
if 'balance' in r:
r['balance'] = int(r['balance'] * COIN)
if 'paytxfee' in r:
r['paytxfee'] = int(r['paytxfee'] * COIN)
return r
return self._call('getnetworkinfo')

def getmininginfo(self):
"""Return a JSON object containing mining-related information"""
Expand Down