fix: resolve opencode via shutil.which and pipe prompts through stdin on Windows - #737
Open
dopamine-pixels wants to merge 1 commit into
Open
Conversation
… on Windows The opencode batch runner invoked the bare name 'opencode', which CreateProcess cannot resolve for npm-installed .cmd shims on Windows (WinError 2, exit 127). Mirror the codex runner: resolve the executable with shutil.which, wrap .cmd/.bat shims in 'cmd /c', and send the prompt via stdin instead of argv when the wrapper is used (cmd.exe re-parses argv and mangles prompts containing quotes or angle brackets).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
desloppify review --run-batches --runner opencode fails on Windows when opencode is npm-installed. The runner invokes the bare name opencode, which CreateProcess cannot resolve for the npm .cmd shim — every batch exits 127 with [WinError 2] The system cannot find the file specified, and the run reports "Runner CLI not found on PATH" even though opencode is on PATH.
Fix
Mirror the existing codex runner handling:
un_batch_attempt plumbing already supported stdin). .exe binaries and non-Windows platforms keep argv prompt passing.
Verification
un_opencode_batch).