Skip to content

Fix Codex batch config quoting on Windows - #730

Open
AustenMan wants to merge 1 commit into
peteromallet:mainfrom
AustenMan:fix/windows-codex-config-quoting
Open

Fix Codex batch config quoting on Windows#730
AustenMan wants to merge 1 commit into
peteromallet:mainfrom
AustenMan:fix/windows-codex-config-quoting

Conversation

@AustenMan

Copy link
Copy Markdown

Summary

  • pass Codex configuration overrides without embedded TOML quotes
  • verify the collapsed Windows cmd command contains parseable overrides and no backslash-escaped quote sequence
  • make the existing reasoning-effort test work with the collapsed Windows command shape

Problem

On Windows, subprocess.list2cmdline escaped the embedded quote characters before invoking an npm codex.cmd shim. cmd.exe passed those backslashes literally, and every Desloppify review batch failed immediately with an invalid approval_policy value.

Validation

  • the exact prior command failed with an unknown approval-policy variant containing a backslash and quote
  • both unquoted override values are accepted by codex-cli 0.153.0 through cmd.exe
  • python -m pytest desloppify/tests/commands/test_runner_modules_direct.py -q: 12 passed
  • Ruff check passes for both changed files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant