Repository navigation
[ENHANCEMENT] add custom ca flag - #381
Merged
Merged
Conversation
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Nexucis
reviewed
Nov 10, 2026
Nexucis
left a comment
Nexucis
left a comment
Member
There was a problem hiding this comment.
Thanks @jgbernalp, the generic fileReloader is a nice refactoring, and the mTLS setup looks correct to me.
Two things I'd like to see addressed (see the inline comments):
- the comment saying that the resumed sessions are verified again with the new CA is right, but it is a security property that no test covers;
ClientCAsshould also be set on the base config, so it fails closed instead of falling back to the system CAs.
The other comments are nits.
FWIW, go test -race ./echo/... and golangci-lint v2.15.0 pass locally, and rotating the CA under 16 concurrent mTLS clients with -race showed no race and no failed request.
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
Contributor
Author
|
@Nexucis comments addressed, please check again. |
Nexucis
approved these changes
Nov 10, 2026
Nexucis
left a comment
Nexucis
left a comment
Member
There was a problem hiding this comment.
Thanks @jgbernalp, all the comments are addressed, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #278