Repository navigation
api: default omitted v2 connect timeouts to five minutes - #58
Merged
Merged
Conversation
zibi-pplx
marked this pull request as ready for review
October 5, 2026 19:17
kumarpallav-pplx
self-requested a review
October 5, 2026 19:35
kumarpallav-pplx
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E2B SDK 2.51/2.52 omits the connect timeout unless the caller supplies it (upstream SDK change). The v2 server contract defaults this omission to 300 seconds, but SPACE previously routed v2 through the legacy activity-only omission behavior.
For a sandbox with a 120-second AccessIdle policy and no later extension, the previous SDK's explicit
timeout: 300established a five-minute minimum. The new SDK's{}only touched activity, leaving a 120-second deadline.{}, explicit short/default/long timeout, running and resumed sandboxes, 120/300/900-second policies, and a pre-existing later extension.No template sizing, networking policy, create behavior, deployment configuration, or other compatibility changes.
Severity
High: an SDK upgrade can reduce the post-connect lifetime of sandboxes with short idle policies, causing earlier suspension or deletion than the caller's default five-minute guarantee.
Validation
started / 120s / v2 empty bodybecause the requested extension is absent. The explicit-zero route assertion also fails before the fix (404 instead of 400).cargo fmt -p pplx-space-api -- --check: passed.cargo test --locked -p pplx-space-api --lib connect -- --nocapture --test-threads=2: 37 passed, 0 failed, 0 ignored. This includes the 54-case deadline matrix and v2 explicit-zero rejection.cargo clippy --locked -p pplx-space-api --all-targets --all-features -- -D warnings: passed.space-nextest-postgres-setupbinary and selected viaSPACE_TEST_POSTGRES_ADMIN_URL;SPACE_CI_REQUIRE_TEST_DEPS=1was set. No database-dependent test was skipped.access_extended_untiland retained lifecycle policy. It does not simulate the native lifecycle scheduler.cargo test --locked -p pplx-space-sbx-mgr --lib connect_floor_survives_activity_without_changing_policy_or_other_clocks -- --nocapture: 1 passed, 0 failed, 0 ignored. This existing native scheduler test independently verifies that extensions do not shorten the effective deadline and survive subsequent activity without rewriting policy.pre-commit run gitleaks: passed; staged code, surrounding context and proposed PR text reviewed for public-safe content, with no findings in that scope.Task-owned PostgreSQL fixtures were removed; no test databases remain. No live sandbox, Firecracker, Kubernetes, deployment or full-workspace qualification is claimed.
Assistance
Perplexity Computer implemented this change, added the regression coverage, and drafted this description.