Skip to content

impr: change parallel test from _test_parallel to _parallel_test#896

Open
speeddragon wants to merge 3 commits intoedgefrom
fix/parallel_warning
Open

impr: change parallel test from _test_parallel to _parallel_test#896
speeddragon wants to merge 3 commits intoedgefrom
fix/parallel_warning

Conversation

@speeddragon
Copy link
Copy Markdown
Collaborator

Avoid parallel test warning of function not being used, because it ends on _test_parallel and not _parallel_test. All other test helpers would also show a warning of not being used, so this fixes that.

@speeddragon
Copy link
Copy Markdown
Collaborator Author

Failed: 3. Skipped: 0. Passed: 3059.

@speeddragon speeddragon marked this pull request as ready for review May 1, 2026 16:07
@speeddragon speeddragon marked this pull request as draft May 1, 2026 21:58
@speeddragon speeddragon marked this pull request as ready for review May 1, 2026 22:25
@samcamwilliams
Copy link
Copy Markdown
Collaborator

Interesting... What happens if the module has -include_lib with eunit before the hb.hrl include? Or after? How do we stop these redefinitions conflicting with the eunit parse transform?

Additionally, if all we are trying to do is avoid the warning, can't we just add the exports for the test_parallel[_] functions, just like the eunit parse transform does?

@speeddragon
Copy link
Copy Markdown
Collaborator Author

speeddragon commented May 4, 2026

Interesting... What happens if the module has -include_lib with eunit before the hb.hrl include? Or after?

eunit.hrl' included before hb.hrl' will make tests run twice.

Additionally, if all we are trying to do is avoid the warning, can't we just add the exports for the test_parallel[_] functions, just like the eunit parse transform does?

I will check that solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants