fix: stack trace formatting and proper ensure_started call#840
Open
fix: stack trace formatting and proper ensure_started call#840
Conversation
shyba
force-pushed
the
fix/system-monitor2
branch
from
0781501 to
9267775
Compare
speeddragon
reviewed
Apr 16, 2026
shyba
force-pushed
the
fix/system-monitor2
branch
from
9267775 to
9c753a4
Compare
speeddragon
reviewed
Apr 21, 2026
speeddragon
reviewed
Apr 21, 2026
shyba
force-pushed
the
fix/system-monitor2
branch
from
9c753a4 to
9aaffaf
Compare
speeddragon
reviewed
Apr 22, 2026
Comment on lines
155
to
156
| format_location(undefined) -> | ||
| <<"undefined">>; |
Collaborator
There was a problem hiding this comment.
Sorry, I missed one thing in your PR, but it isn't critical.
If you think undefined could be common, that should be moved to hb_format:format_mfa function.
speeddragon
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those are fixes pending from #824