umpf: propagate umpf push exit code#64
Merged
michaelolbrich merged 1 commit intopengutronix:masterfrom Apr 17, 2026
Merged
Conversation
hnez
approved these changes
Mar 20, 2026
Member
hnez
left a comment
hnez
left a comment
There was a problem hiding this comment.
I am not much of a shell scripting expert, but I think this looks good.
Thanks for looking into this!
michaelolbrich
requested changes
Apr 16, 2026
cleanup is called at the end of many operations and it doesn't not take care of saving the last exit code. This results in an umpf push failing at the final git push step to not exit with an error status. This makes it difficult to use umpf push in a CI setup, where no one looks at job output if the job did not signal an error. Propagate the error code through cleanup to fix this. Reported-by: Leonard Göhrs <l.goehrs@pengutronix.de> Closes: pengutronix#63 Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
michaelolbrich
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An umpf push that fails at the final git push step does not exit with an error status.
This makes it difficult to use umpf push in a CI setup, where no one looks at job output if the job did not signal an error.
Propagate the error code to fix this.
Reported-by: Leonard Göhrs l.goehrs@pengutronix.de
Closes: #63