Make the Known-open issues list describe the live product - #30
Merged
Conversation
The JPY hero-balance line described the twelve-entry hand-typed catalog that src/lib/money.ts replaced with the generated 162-code table; the code's own comment already documents the fix, and money.test.ts pins JPY at 0 decimals in five locales. Verified today across every live surface: currencyInfo falls back to the bundled CLDR table before its 2-decimal placeholder, and /api/currencies serves the identical generated table, so the catalog query resolving can never change a decimal count. The 2^53 line is still true of apps/api, but apps/api serves no route and no traffic — saying so stops the next reader auditing dead code while implying the live money path shares the defect it does not have. Ordered-By: Hugo0 Order: https://github.com/peanutprotocol/peanutsplit/blob/main/ops/steward/HANDOFF-2026-09-02-showhn.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show-HN handoff Tasks 1–3 (ordered by Hugo, ops/steward/HANDOFF-2026-09-02-showhn.md — copied into the repo in this PR so the Order: trailer resolves).
Task 1 verdict: the JPY 100× flash is NOT REAL on live apps/web. The claim described the old hand-typed 12-entry fallback. Today:
currencyInfo→ caller catalog → bundled generatedcurrency-catalog.ts(162 codes, CLDR decimals: JPY=0, BHD=3) → 2-decimal placeholder that only custom tickers reach (by design, documented in the catalog header)./api/currenciesserves the identical generated table, so the resolved catalog cannot disagree with the bundled one. No manual/100on any money surface (the one hit is percentage weights). 160/160 money+split unit tests pass, including JPY formatting in 5 locales and digits past 2^53.Task 2: confirmed — apps/api is vestigial (no Traefik router, zero requests in supervisor logs since Aug 18); not fixed per order. apps/web money path is string/BigInt end-to-end; the single Number crossing (
minorToExactNumber) is round-trip-guarded and refuses ≥2^53.Task 3: this PR — both lines rewritten to describe the live product.
Docs-only; no code changes.