fix(table): various accessibility issues

[atharv-g-kulkarni]

What I did

• Fixed issues mentioned in the issue.
• Improved accessibility score of pf-table (Table, Expandable Rows Compound, Sortable) from 91 to 100

Before:

After:

---

• Improved accessibility score of pf-table (Expandable Rows) improved from 81 to 90.

Before:

After:

[changeset-bot]

🦋 Changeset detected

Latest commit: db81c44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@patternfly/elements	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

✅ Commitlint tests passed!

More Info

{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(table): fix table accessibility issue-2813"
}

[netlify]

✅ Deploy Preview for patternfly-elements ready!

Name	Link
🔨 Latest commit	db81c44
🔍 Latest deploy log	https://app.netlify.com/projects/patternfly-elements/deploys/69df82efdf6a370008fec253
😎 Deploy Preview	https://deploy-preview-2885--patternfly-elements.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[zeroedin]

So enacting the requested changes myself locally I think I opened a broader issue here. Because we are using button as an expander, and using aria-expanded on it we equally need a aria-controls which isn't currently being applied. Also due to the fact the element being opened#expansion is across shadow dom roots I'm going to assume we are going to run into cross root aria issues with that.

@adamjohnson when you get the chance lets review this together.

[bennypowers]

can the button's aria-controls reference be to the row on

patternfly-elements/elements/pf-table/pf-tr.ts

Line 125 in 1e2f9a1

<div id="container" role="${ifDefined(this.expandable ? 'row' : undefined)}">

?