Restore the release trigger and ship 3.1.1 - #51
Merged
Merged
Conversation
added 2 commits
September 22, 2026 05:04
Dropping every automatic trigger took the pull request runs away, which was the point, and took releases with it, which was not. The publish job is gated on `github.event_name == 'push'` and diffs Cargo.toml against `github.event.before`, both of which only exist on a push. With workflow_dispatch alone that job can never run, so 3.1.0 merged to master and published nothing, and crates.io stayed on 3.0.3. Master keeps its push trigger. Pull requests stay off. workflow_dispatch stays so the workflow can still be run on request.
3.1.0 exists as a tag in this repository's history and nowhere else: it merged while the publish job could not fire. The publish step diffs Cargo.toml against the previous master commit, so restoring the trigger alone would find no change and release nothing. 3.1.1 carries the same nagoya socket work 3.1.0 was meant to. No source change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a release I broke in #50, and ships the same work as 3.1.1.
What went wrong
#50 removed every automatic trigger from
rust.yml, which correctly stoppedpull request runs and incorrectly stopped releases.
The
publishjob is gated ongithub.event_name == 'push' && github.ref == 'refs/heads/master'and readsgithub.event.beforeto diffCargo.toml. Bothonly exist on a push event. With
workflow_dispatchalone that job could neverrun, and a manual dispatch would not have helped:
github.event.beforeis emptyoutside a push, so the diff would be meaningless.
So 3.1.0 merged to master, no workflow fired at all, and crates.io is still on
3.0.3.
What this does
4fdefdaputs the master push trigger back and leavespull_requestoff. Pull requests still do not run CI; master does, because on this
repository a push to master is the release.
workflow_dispatchstays.719f81abumps to 3.1.1. The publish step diffsCargo.tomlagainst theprevious master commit, so restoring the trigger on its own would find no
change and release nothing. No source change; 3.1.1 carries exactly the nagoya
socket work 3.1.0 was meant to carry.
3.1.0 will exist in this repository's history and never on crates.io. That is
the honest outcome and it costs a patch number.
Local gate
a_wire_message_crosses_a_nagoya_unix_socket_in_both_directions ... okThe workflow was parsed rather than eyeballed, since a bad trigger is the defect
being fixed:
The
ifnow matches a trigger that exists.After merge
The push to master fires the workflow,
Cargo.tomldiffers from the previouscommit, and
cargo publishruns. Watch for 3.1.1 on crates.io rather thanassuming it; the whole point of this PR is that a merge without a run is a
release that did not happen.