fix: managed install archive extraction path mismatch + e2e MCP tests#136
Merged
Conversation
cargo-dist archives extract to patchloom-<triple>/patchloom, but the promotion step expected the binary at managed-bin/patchloom. The rename failed with ENOENT on every real managed install attempt. Fix: after extraction, detect the cargo-dist subdirectory and move the binary to the expected staged path before promotion. Also add end-to-end tests that perform a real managed install (download from GitHub, verify checksum, extract, promote) then start the MCP server and validate JSON-RPC initialize and tools/list responses. These tests would have caught this bug on day one. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix
cargo-dist archives extract to
patchloom-<triple>/patchloom, butpromoteManagedInstallBinaryexpected the binary atmanaged-bin/patchloom. The rename failed with ENOENT on every realmanaged install attempt. This means the "Install Patchloom" command
in the extension has never worked for users who rely on managed install.
Fix: after extraction, detect the cargo-dist subdirectory and move
the binary to the expected staged path before promotion.
New end-to-end tests (4 tests)
Added a
managed install end-to-end MCPdescribe block that:performManagedInstallwith real downloads from GitHub(no mocks, no injected I/O)
--version)initializerequesttools/listand validates every tool has a name andinputSchemaThese tests prove the full pipeline works on a clean machine with no
pre-installed binary: download, checksum verify, extract, promote,
launch MCP, and interact via JSON-RPC.
If network is unavailable, the tests skip gracefully.
Results
managed.tscoverage increased from 88.61% to 91.39%