Skip to content

fix(editor): guard model export against undefined geometry.index (Sentry MONOREPO-EDITOR-E0) #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anton-pascal wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −0
Open

fix(editor): guard model export against undefined geometry.index (Sentry MONOREPO-EDITOR-E0) #447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/editor/src/lib/glb-export.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ export function prepareSceneForExport(
}

pruneNonRenderableMeshes(scene, identityNodes)
normalizeGeometryIndex(scene)
convertMaterials(scene)

const { clips, clipNamesByNode } = bakeAnimationClips(cloneByOriginal, nodes)
Expand Down Expand Up @@ -219,6 +220,24 @@ function pruneNonRenderableMeshes(root: THREE.Object3D, identityNodes: Set<THREE
}
}

/**
* Coerce every surviving mesh's `geometry.index` from `undefined` to `null`.
* three r184's STLExporter (and the OBJ/GLB paths) guard with `index !== null`
* and then read `index.count`; a `BufferGeometry` whose index was never set
* reports `undefined`, which passes that guard and crashes with
* `Cannot read properties of undefined (reading 'count')`. `BufferGeometry`
* treats `null` as "no index" (non-indexed draw), so this is the safe form the
* exporters expect. Fixes Sentry MONOREPO-EDITOR-E0.
*/
function normalizeGeometryIndex(root: THREE.Object3D) {
root.traverse((object) => {
const mesh = object as THREE.Mesh
if (!mesh.isMesh) return
const geometry = mesh.geometry as THREE.BufferGeometry | undefined
if (geometry && geometry.index === undefined) geometry.index = null
})
}

function isRenderableMesh(mesh: THREE.Mesh): boolean {
const position = mesh.geometry?.getAttribute('position')
if (!position || position.count === 0) return false
Expand Down
Loading