fix(doors): bake open-animation clips for every operation door + un-flipped rest pose

[wass08]

What

Bake an open-animation clip into the GLB for every openable/slideable door driven by the edition panel — not just hinged/swing doors. Previously sliding, pocket, barn, folding, and all garage doors baked their operationState straight into mesh vertices at build time, so the exported GLB had no re-poseable node and no open clip.

How

Gives operation doors the same build-once + pose-at-t split the windows already use:

• Each builder in door-system.tsx emits its moving parts in a named group at the closed pose.
• A new exported poseDoorMovingParts(node, mesh, t) is the single source of truth for the open motion — the live system poses after each rebuild, and the GLB exporter poses a clone to sample keyframes.
• glb-export.ts bakeDoorClip dispatches operation types to bakeOperationDoorClip (samples 16 segments → position/quaternion/scale tracks for any moving group; resets closed) vs the renamed bakeSwingDoorClip.

Per-type rigs: sliding/pocket/barn = leaf translate; garage-tiltup = rigid hinge about the lintel; folding = nested-group accordion chain; garage-sectional = per-panel groups along the overhead curve. garage-rollup is the one exception — its slats genuinely vanish onto a drum (not expressible as a glTF clip), so it keeps its live rebuild and the exporter scales a top-pivoted curtain group as the agreed approximation.

Follow-up fixes folded in

• Folding fold direction was inverted (+z into the room) — corrected to fold −z, parity-tested panel-for-panel.
• Open-clip names were ${node.name}: open, so multiple same-named windows/doors collided (the baked viewer keys useAnimations by clip name) — now ${id}: open (unique; display name stays in extras.label).
• Un-flipped rest pose (last commit): a folding door saved open baked a 180°-flipped rest. The export clones + decomposes the door matrix, which re-derives a gimbal-flipped euler (x=z=π) for any rotation beyond ±90° (folding reaches ~158°); the pose reset only zeroed .y, leaving the π residue. Fixed by setting the full euler triple in every pose branch.

Tests

• door-animation.test.ts — per-type kinematics.
• glb-export.test.ts — sliding (sampled position) + rollup (sampled scale) clips, and a regression asserting an identity rest pose for an open folding door.

Validation

Baked a real project end-to-end locally (headless worker → served lod0.glb): all door-fold panels rest at identity [0,0,0,1] with the open clip targeting every panel; sliding/pocket/barn/folding clips present with correct group targets.

---

Note

Medium Risk
Touches door mesh construction, GLB animation baking, and clip naming used by the baked viewer—regressions could affect export rest poses or which door animates on interaction, but scope is well covered by new tests.

Overview
Operation doors (sliding, pocket, barn, folding, garage types) now follow the same build closed + pose at t pattern as windows: moving geometry lives in named groups, shared poseDoorMovingParts drives live view and export, and bakeOperationDoorClip samples 16 steps into position/rotation/scale tracks (roll-up uses a scale approximation on door-rollup-curtain while live roll-up still rebuilds slats).

GLB open clips are named ${nodeId}: open instead of display names so duplicate labels do not collapse useAnimations actions; human names stay in extras.label.

Folding rig is a parented panel chain; pose resets the full euler so export does not bake a gimbal-flipped rest when operationState was saved open.

Walkthrough temporarily sets perspective camera FOV to 60° (WALKTHROUGH_FOV) in editor and baked GLB controllers, restored on exit.

Tests cover per-type kinematics, sliding/rollup export clips, and folding identity rest pose.

^{Reviewed by Cursor Bugbot for commit 61f3921. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Roll-up export rest not closed

Medium Severity

For roll-up garage doors, bakeOperationDoorClip doesn't fully reset the door to a closed state for GLB export. The poseDoorMovingParts(..., 0) call only adjusts scale, leaving the slat geometry's height partially open. This results in a mismatched GLB rest pose and an incorrect animation clip baseline.

 

^{Reviewed by Cursor Bugbot for commit 7530de5. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 61f3921. Configure here.}

[cursor]

Roll-up GLB bake geometry mismatch

Medium Severity

The garage-rollup door's addGarageRollupDoor function builds the ROLLUP_CURTAIN_NAME group based on the current operationState. This conflicts with GLB export, which expects this group to be built at its full, closed height and then scaled by poseDoorMovingParts. As a result, GLB exports of garage-rollup doors will have an incorrect rest pose or missing animation if the door is not fully closed when exported.

 

^{Reviewed by Cursor Bugbot for commit 61f3921. Configure here.}