Skip to content

Feat/more code actions#211

Open
roife wants to merge 4 commits into
masterfrom
feat/more-code-actions
Open

Feat/more code actions#211
roife wants to merge 4 commits into
masterfrom
feat/more-code-actions

Conversation

@roife
Copy link
Copy Markdown
Member

@roife roife commented May 31, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 31, 2026 19:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link
Copy Markdown

Docs preview: https://vide.pascal-lab.net/preview/pr-211/

Comment thread crates/ide/src/code_action/edits.rs
added.then_some(())
}

fn expand_postfix(collector: &mut CodeActionCollector, ctx: &CodeActionCtx) -> Option<()> {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for complicated expression like y=i++ (idk if this example is valid in verilog) this would expand to y=i=i+1, would it make users confusing?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked it. We should do more checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants