Repository navigation
Pin slang fix for overflowing replication widths - #2
Closed
willpartcl wants to merge 1 commit into
Closed
willpartcl wants to merge 1 commit into
willpartcl wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the slang submodule to the fix for overflowing replication widths. The change widens the multiplication before the existing width check, avoiding SIGSEGV during constant folding of oversized nested replication expressions.
Depends on partcleda/slang#5. Keep this draft until that dependency is ready. Upstream tests pass: 2,208 test cases, including overflow and maximum-valid-width regressions. The only change here is the submodule pointer; Boson's native elaborator integration and CLI reproduction are being tested against this exact pin.
Refs partcleda/boson#5421.
AI disclosure: prepared with OpenAI Codex.
Need help on this PR? Tag
@codesmith-botwith what you need.