Repository navigation
fix(ast): instance cache key descends arrayed interface ports by elements - #4
Merged
Merged
Conversation
…ents Cherry-pick of upstream MikePopoloski/slang bb629fe (MikePopoloski#1949, fixes MikePopoloski#1947), carried by boson as scripts/patches/slang/0009. The array a port connection carries has elements and no scope members, so Scope::empty() dropped the interface from the instance cache key and two instances bound to different interface arrays shared one body. (cherry picked from commit bb629fe) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of upstream MikePopoloski/slang bb629fe (MikePopoloski#1949, fixes upstream MikePopoloski#1947), with its unit test.
boson carries this today as
scripts/patches/slang/0009-instance-cache-key-arrayed-interface-ports.patch(partcleda/boson#12943). It is the last boson-local slang patch not yet onboson-base; with it,boson-basesource equals the pinned upstream slang (f04e815) plus all twelve boson patches, except that #2 spellsstd::unique_lock<std::mutex>where boson's 0010 uses CTAD (same type). boson will then build slang from this branch and drop its patch directory.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.