feat: add PromQL chart view#99
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds interactive charting to the PromQL UI: introduces mode-aware fetching and step resolution, persists raw timestamps, extends PromqlModel with chart state and cursor/hover, wires keyboard chart/table toggles and cursor navigation, renders time-series via ntcharts, and supplies unit tests and dependency upgrades. ChangesPromQL Chart Visualization
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/ui/chrome.go`:
- Around line 192-193: KeyGrid currently forwards inputs to buildKeyGrid without
validating cols which can cause a divide-by-zero panic; change KeyGrid to guard
cols (e.g., if cols <= 0 then set cols = 1 or return an empty string) before
calling buildKeyGrid, and optionally validate availW similarly (clamp to a
non-negative value) so buildKeyGrid never receives a zero/negative column count;
update KeyGrid to perform this check and then call buildKeyGrid(keys, cols,
availW).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 481f880d-58d8-4936-8863-e67ff4c1854d
📒 Files selected for processing (5)
cmd/promql.gopkg/model/promql.gopkg/model/promql_test.gopkg/model/query.gopkg/ui/chrome.go
✅ Files skipped from review due to trivial changes (1)
- pkg/model/query.go
🚧 Files skipped from review as they are similar to previous changes (1)
- pkg/model/promql.go
###Change
Summary by CodeRabbit
New Features
Tests
Chores
UI