ci(release): publish only from tag pushes, fix Usage and Deployments in release notes - #325
Conversation
…ge and Deployments
CI Summary
Deploy ContractsDeployed addresses vs the expected setExpected is the committed expected-address set; actual is this CI deployment of the same pipeline.
Labelsother, type: docs |
|
Looks good overall, a few things:
|
GHkrishna
left a comment
There was a problem hiding this comment.
We should also delete the leftover draft from the failed run before tagging that version again?
| # The tag that started this run; `target_commitish` is that tag's commit. | ||
| tag_name: ${{ env.RELEASE_TAG }} | ||
| target_commitish: ${{ github.sha }} | ||
| files: | |
There was a problem hiding this comment.
Nit: target_commitish does nothing now that the tag always exists. Fine to leave or drop?
Yes, I'll remove
Added to the README's failed-run paragraph in b1c56ab
Added to the release body in b1c56ab : bare semver ( |
Description
Fixes the release-pipeline problems hit while publishing v1.0.0.
Dispatch runs could not publish. The
release tagsruleset lets only the dotns team createv*tags. Aworkflow_dispatchrun built and tested everything, created the draft, and then failed at "Publish release": publishing a draft is the moment GitHub creates its tag, and the workflow token is not allowed to (Cannot create ref due to creations being restricted).Both publish workflows now run only on a tag push:
workflow_dispatchis removed frompublish-release.ymlandpublish-prerelease.yml.github.ref_name, which is now always the tag.Release body fixes
Store.json, which no release ships. It now importsLabelStore.json(both workflows).protocolVersion()Docs are also fixed accordingly.
Type
Scope
Related Issues
Fixes
Issues during the v1.0.0 release process.
Checklist
Code
forge buildpassesforge testpassesTesting
Security
selfdestructordelegatecallDocumentation
Breaking Changes
Breaking changes:
How to test
You could test it by triggering a new pre-release.
Notes
releasesenvironment still allowsmasteras a deployment ref, which only the dispatch path used. Remove it so the environment matches RELEASE_ARTIFACTS.