Skip to content

[Feat]: Decide what the pending-claim deadline means #324

Description

@re-gius

Component

Proof of Personhood

Priority

P2

Summary

When the gateway issues a name to an account that has no LabelStore yet, DotnsPopController stores a pending claim, and the label is written into the store later by settlePendingClaims or claimLabelStore. Settlement is permissionless and open at any time: nothing expires a pending claim and nothing restricts who may settle it or when.

DotnsPopLens still reports a deadline on every pending row of namesOf (Name.deadline = mintedAt + reservationDuration). No contract reads or enforces it, so a client could reasonably believe a claim lapses or changes state at that time when it does not. The NatSpec now calls it advisory (#321), but the field itself has no defined meaning.

Proposal

Decide what the deadline is for, then make the code match:

  • If it has no use, remove Name.deadline from the lens. The lens is redeployed with each release, so this is an ABI change for lens readers only.
  • If it should mean something, define what happens after it (for example, who may settle before and after it) and enforce that in DotnsPopController.

No known consumer reads Name.deadline today.

Acceptance criteria

  • The meaning of the pending-claim deadline is decided and written down.
  • The lens and controller match that decision: the field is removed, or the behaviour it describes is enforced and tested.
  • NatSpec and README describe the resulting behaviour.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions