Component
Proof of Personhood
Priority
P2
Summary
When the gateway issues a name to an account that has no LabelStore yet, DotnsPopController stores a pending claim, and the label is written into the store later by settlePendingClaims or claimLabelStore. Settlement is permissionless and open at any time: nothing expires a pending claim and nothing restricts who may settle it or when.
DotnsPopLens still reports a deadline on every pending row of namesOf (Name.deadline = mintedAt + reservationDuration). No contract reads or enforces it, so a client could reasonably believe a claim lapses or changes state at that time when it does not. The NatSpec now calls it advisory (#321), but the field itself has no defined meaning.
Proposal
Decide what the deadline is for, then make the code match:
- If it has no use, remove
Name.deadline from the lens. The lens is redeployed with each release, so this is an ABI change for lens readers only.
- If it should mean something, define what happens after it (for example, who may settle before and after it) and enforce that in
DotnsPopController.
No known consumer reads Name.deadline today.
Acceptance criteria
Component
Proof of Personhood
Priority
P2
Summary
When the gateway issues a name to an account that has no
LabelStoreyet,DotnsPopControllerstores a pending claim, and the label is written into the store later bysettlePendingClaimsorclaimLabelStore. Settlement is permissionless and open at any time: nothing expires a pending claim and nothing restricts who may settle it or when.DotnsPopLensstill reports adeadlineon every pending row ofnamesOf(Name.deadline = mintedAt + reservationDuration). No contract reads or enforces it, so a client could reasonably believe a claim lapses or changes state at that time when it does not. The NatSpec now calls it advisory (#321), but the field itself has no defined meaning.Proposal
Decide what the deadline is for, then make the code match:
Name.deadlinefrom the lens. The lens is redeployed with each release, so this is an ABI change for lens readers only.DotnsPopController.No known consumer reads
Name.deadlinetoday.Acceptance criteria