fix(cli): register works with the implicit dev account and survives store-sync failures by filip-parity · Pull Request #279 · paritytech/dotns-sdk

filip-parity · 2026-09-02T15:15:19Z

Description

Two register bugs found during the previewnet e2e test:

register with no account configured aborted with "Could not resolve a credential for the registration retry cache". The default auth branch was the only one without a credential; it now uses the public dev phrase like the other branches.
A label-store sync failure after a successful registration killed the whole command with a wrong hint ("origin not mapped"). The sync is now best-effort and prints the real error as a warning.

Fixes

Fixes paritytech/dotns#266
Fixes paritytech/dotns#267

Testing

bun test packages/cli/tests/unit/auth covers the credential fallback; full suite passes. Verified on previewnet: register with the implicit account now gets past the credential check.

Version bumped to 0.8.5 for the release guard.

…tore-sync failures Two register-flow fixes found during the previewnet end-to-end test: - The default auth branch was the only one returning no credential, so `register` with the implicit shared dev account aborted on the retry-cache check after resolving a usable signer. It now carries the (public) dev phrase as its credential like every other branch. Fixes paritytech/dotns#266 - A post-registration label-store sync failure escaped from the initial reads and aborted the whole command with the unmapped-origin hint, even though the name was registered, verified, and the account mapped. The sync is now best-effort: failures and unsynced results surface as warnings carrying the real error. Fixes paritytech/dotns#267 Bumps the CLI to 0.8.5 for the release guard.

github-actions · 2026-09-02T15:15:29Z

CI Summary

Check	Result
Lint	Passed
Format	Passed
Typecheck	Passed
Build	Passed
Release	Passed
Deploy Example	Passed
PR Title	Passed
Labels	Passed
Test	Passed - 305 passed, 0 failed

Release - Passed

Test this PR

Download artifact (GitHub CLI required):

gh run download 33736673714 -n cli-release-0.0.0-pr.279 -R paritytech/dotns-sdk

Install globally:

npm install -g ./parity-dotns-cli-0.0.0-pr.279.tgz

Verify:

dotns --help

Deploy Example — Passed

Stage	Status
✓ Site validation	Site validated
✓ Deploy	Deployed

Property	Value
Domain	`pr279.dotns-example-site.dot`
CID	`bafybeicx555prsudvmqsdrap7keoilryrudwycdx3ody2rejwqwjwp52u4`
URL (dot.li)	https://pr279.dotns-example-site.dot.li
URL (paseo.li)	https://pr279.dotns-example-site.paseo.li
URL (direct)	https://pr279.dotns-example-site.dot
Duration	`114s`

View run

Labels

pkg: cli, type: test, dependencies

Test - Passed

305 passed, 0 failed across 305 tests.

View run

$ bun test tests/unit/
bun test v1.2.6 (8ebd5d53)

::group::tests/unit/delegate/delegateHelp.test.ts:
(pass) delegate --help lists set, revoke, status, records and auth options [18.00ms]
(pass) delegate records --help shows operator argument and --revoke [5.00ms]
(pass) delegate records-status --help shows operator argument and --json [3.00ms]
(pass) delegate set --help shows name and delegate arguments [3.00ms]
(pass) delegate revoke --help shows name argument [3.00ms]
(pass) delegate status --help shows name argument and --json [3.00ms]

::endgroup::

::group::tests/unit/pop/setPopHelp.test.ts:
(pass) root help lists pop command [4.00ms]
(pass) pop help shows commands and description [3.00ms]
(pass) pop help shows auth options [3.00ms]
(pass) pop info help shows description [2.00ms]
(pass) pop status help shows description [4.00ms]
(pass) pop info help shows auth options [4.00ms]
(pass) pop info parses auth options at pop level [5.00ms]
(pass) pop info parses auth options at info level [4.00ms]
(pass) pop help command shows pop help [3.00ms]
(pass) pop help status shows info help [3.00ms]
(pass) pop help info shows info help [4.00ms]

::endgroup::

::group::tests/unit/pop/popJson.test.ts:
(pass) pop info --help shows --json option [4.00ms]
(pass) pop status --help shows --json option [1.00ms]

::endgroup::

::group::tests/unit/escrow/escrowHelp.test.ts:
(pass) root help lists escrow command [3.00ms]
(pass) escrow help shows the subcommand description and subcommands [1.00ms]
(pass) escrow balance help describes the claimable pull-payment balance [2.00ms]
(pass) escrow positions help describes the list and total [2.00ms]
(pass) escrow status help describes the read-only position lookup [2.00ms]
(pass) escrow release help describes the approve-and-release sequence [2.00ms]
(pass) escrow withdraw help describes the post-cooldown step [1.00ms]
(pass) escrow claim-withdrawal help describes the overpayment ledger [2.00ms]
(pass) escrow refunds help lists list/claim/claim-batch [2.00ms]
(pass) escrow refunds list help exposes pagination options [1.00ms]
(pass) escrow refunds claim help requires an entry id positional [2.00ms]
(pass) escrow refunds claim-batch help accepts variadic ids [2.00ms]

::endgroup::

::group::tests/unit/escrow/escrowFormatting.test.ts:
(pass) formatRefundEntryLine > marks entries past their cooldown as claimable [1.00ms]
(pass) formatRefundEntryLine > marks entries inside their cooldown window with remaining seconds
(pass) formatRefundEntryLine > renders the amount as a PAS decimal string [1.00ms]
(pass) formatRefundEntryLine > truncates large tokenIds for terminal display
(pass) totalEscrowAmount > is zero for no positions
(pass) totalEscrowAmount > sums position amounts
(pass) isRefundableDeposit > is true only when the position holds an amount
(pass) cooldownRemainingSeconds > returns the seconds left, clamped to zero once elapsed
(pass) formatCooldown > formats seconds and minutes
(pass) formatPositionStatus > held when not released
(pass) formatPositionStatus > embeds the cooldown countdown while released and waiting
(pass) formatPositionStatus > claimable once the cooldown elapses
(pass) formatPositionStatus > claimed after withdrawal
(pass) formatPositionsTable > returns no lines for an empty set
(pass) formatPositionsTable > renders a header plus one aligned row per position with the cooldown [1.00ms]
(pass) pendingRefunds multi-output decode > decodes to a [ids, entries] tuple [4.00ms]
(pass) pendingRefunds multi-output decode > decodes an empty ledger to a pair of empty arrays [1.00ms]

::endgroup::

::group::tests/unit/lookup/lookupNormalisation.test.ts:
(pass) lookup normalises fully-qualified names > performDomainLookup derives the same node for `alice` and `alice.paseo` [2.00ms]
(pass) lookup normalises fully-qualified names > performOwnerOfLookup derives the same tokenId for `alice` and `alice.paseo` [1.00ms]
(pass) lookup normalises fully-qualified names > a name under a different suffix is not stripped

::endgroup::

::group::tests/unit/lookup/lookupHelp.test.ts:
(pass) lookup --help lists subcommands and auth options [3.00ms]
(pass) lookup name --help shows label argument and options [2.00ms]
(pass) lookup owner-of --help shows label argument and options [2.00ms]
(pass) lookup transfer --help shows label argument and destination option [2.00ms]
(pass) lookup transfer parses destination at transfer level [2.00ms]
(pass) lookup transfer parses auth options at lookup level [2.00ms]

::endgroup::

::group::tests/unit/store/storeHelp.test.ts:
(pass) store --help lists subcommands [3.00ms]
(pass) store claim --help shows description and auth options [1.00ms]
(pass) store info --help shows auth options [2.00ms]
(pass) store list --help shows options [2.00ms]
(pass) store get --help shows key argument [2.00ms]
(pass) store set --help shows key and value arguments with auth [1.00ms]
(pass) store delete --help shows key argument with auth [2.00ms]

::endgroup::

::group::tests/unit/auth/authHelp.test.ts:
(pass) root help lists auth command [3.00ms]
(pass) auth help shows options and subcommands [1.00ms]
(pass) auth set help shows all options [2.00ms]
(pass) auth list help shows options [2.00ms]
(pass) auth use help shows options [1.00ms]
(pass) auth remove help shows options [2.00ms]
(pass) auth clear help shows options [2.00ms]
(pass) auth parses keystore-path option [2.00ms]
(pass) auth parses password option [2.00ms]
(pass) auth set parses account option [1.00ms]
(pass) auth set parses mnemonic option [2.00ms]
(pass) auth set parses key-uri option [2.00ms]
(pass) auth help command shows help [3.00ms]
(pass) auth help set shows set command help [2.00ms]
(pass) auth help list shows list command help [3.00ms]
(pass) auth help use shows use command help [2.00ms]
(pass) auth help remove shows remove command help [4.00ms]
(pass) auth help clear shows clear command help [3.00ms]

::endgroup::

::group::tests/unit/auth/resolveAuthSourceReadOnly.test.ts:
(pass) resolveAuthSourceReadOnly honours environment variables > $label [2.00ms]
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label
(pass) resolveAuthSourceReadOnly honours environment variables > $label

::endgroup::

::group::tests/unit/auth/authRevert.test.ts:
(pass) auth set rejects account name with forward slash [7.00ms]
(pass) auth set rejects account name with backslash [4.00ms]
(pass) auth set rejects account name that is just a dot [5.00ms]
(pass) auth set rejects account name that is double dots [2.00ms]
(pass) auth set rejects account name starting with dot [3.00ms]
(pass) auth set rejects account name ending with dot [2.00ms]
(pass) auth set rejects account name with special characters [17.00ms]
(pass) auth set rejects account name that is too long [3.00ms]
(pass) auth use rejects non-existent account [83.00ms]
(pass) auth remove rejects non-existent account [66.00ms]

::endgroup::

::group::tests/unit/auth/auth.test.ts:
(pass) auth set creates keystore and stores multiple accounts [283.00ms]
(pass) auth set accepts account names with special characters [413.00ms]
(pass) auth list reports missing keystore [6.00ms]
(pass) auth list shows all accounts and auth types [283.00ms]
(pass) auth use switches default account [412.00ms]
(pass) auth remove last account clears default [69.00ms]
(pass) auth remove preserves remaining accounts and reassigns default [209.00ms]
(pass) auth clear deletes all accounts [73.00ms]
(pass) resolveAuthSource prefers selected keystore account over ambient env mnemonic [206.00ms]
(pass) resolveAuthSource resolves from env mnemonic when only the default keystore path is given
(pass) resolveAuthSource prefers selected keystore account over ambient env key URI [142.00ms]
(pass) auth set rejects weak password supplied by flag for new keystore [6.00ms]
(pass) auth set rejects weak password supplied by env for new keystore [3.00ms]
(pass) resolveAuthSource default branch carries the dev credential for the retry cache

::endgroup::

::group::tests/unit/content/contentJson.test.ts:
(pass) content view --help shows --json option [3.00ms]
(pass) content set --help shows --json option [2.00ms]
(pass) content set --json emits JSON error when both mnemonic and key-uri provided [2.00ms]

::endgroup::

::group::tests/unit/content/contentHelp.test.ts:
result:  {
  exitCode: 0,
  standardOutput: "Usage: dotns content [options] [command]\n\nManage domain content hashes\n\nOptions:\n  --env <environment>            DotNS environment: paseo-v2 (env: DOTNS_ENV)\n  --network <environment>        Alias for --env\n  --rpc <wsUrl>                  WebSocket RPC endpoint (env: DOTNS_RPC)\n  --keystore-path <path>         Keystore path (env: DOTNS_KEYSTORE_PATH)\n  --account <name>               Keystore account name (default: keystore\n                                 default)\n  --password <pw>                Keystore password (env:\n                                 DOTNS_KEYSTORE_PASSWORD)\n  -m, --mnemonic <phrase>        BIP39 mnemonic phrase (env: DOTNS_MNEMONIC)\n  -k, --key-uri <uri>            Substrate key URI (env: DOTNS_KEY_URI)\n  --signer <kind>                Signer: keystore (default) or qr [experimental]\n                                 (env: DOTNS_SIGNER) (default: \"keystore\")\n  --qr-app-id <id>               App id for QR pairing (env: DOTNS_QR_APP_ID)\n  --qr-people-rpc <stageOrUrls>  QR pairing relay: paseo|preview|stable or wss\n                                 URLs (env: DOTNS_QR_PEOPLE_RPC)\n  --qr-fresh                     Force a fresh QR pairing, ignoring any cached\n                                 session\n  -h, --help                     display help for command\n\nCommands:\n  view [options] <name>          View domain content hash\n  set [options] <name> <cid>     Set domain content hash (IPFS CID)\n  help [command]                 display help for command\n",
  standardError: "",
  combinedOutput: "Usage: dotns content [options] [command]\n\nManage domain content hashes\n\nOptions:\n  --env <environment>            DotNS environment: paseo-v2 (env: DOTNS_ENV)\n  --network <environment>        Alias for --env\n  --rpc <wsUrl>                  WebSocket RPC endpoint (env: DOTNS_RPC)\n  --keystore-path <path>         Keystore path (env: DOTNS_KEYSTORE_PATH)\n  --account <name>               Keystore account name (default: keystore\n                                 default)\n  --password <pw>                Keystore password (env:\n                                 DOTNS_KEYSTORE_PASSWORD)\n  -m, --mnemonic <phrase>        BIP39 mnemonic phrase (env: DOTNS_MNEMONIC)\n  -k, --key-uri <uri>            Substrate key URI (env: DOTNS_KEY_URI)\n  --signer <kind>                Signer: keystore (default) or qr [experimental]\n                                 (env: DOTNS_SIGNER) (default: \"keystore\")\n  --qr-app-id <id>               App id for QR pairing (env: DOTNS_QR_APP_ID)\n  --qr-people-rpc <stageOrUrls>  QR pairing relay: paseo|preview|stable or wss\n                                 URLs (env: DOTNS_QR_PEOPLE_RPC)\n  --qr-fresh                     Force a fresh QR pairing, ignoring any cached\n                                 session\n  -h, --help                     display help for command\n\nCommands:\n  view [options] <name>          View domain content hash\n  set [options] <name> <cid>     Set domain content hash (IPFS CID)\n  help [command]                 display help for command\n",
}
(pass) content --help lists subcommands and auth options [4.00ms]
(pass) content view --help shows name argument and options [2.00ms]
(pass) content set --help shows name and cid arguments [1.00ms]

::endgroup::

::group::tests/unit/primary/primaryHelp.test.ts:
(pass) primary --help lists set, status and auth options [3.00ms]
(pass) primary set --help shows name argument and --json [1.00ms]
(pass) primary status --help shows optional address argument and --json [3.00ms]

::endgroup::

::group::tests/unit/bulletin/bulletinAuthorizer.test.ts:
(pass) bulletin authorizer default > defaults to //Eve, the seeded AllowedAuthorizers account
(pass) bulletin authorizer default > is distinct from the sudo key, which stays //Alice
(pass) warnIfDevKeyOnTestnet > warns when the default authorizer is used against previewnet
(pass) warnIfDevKeyOnTestnet > stays silent on paseo-v2 even with the default authorizer
(pass) warnIfDevKeyOnTestnet > stays silent when an explicit signer overrides the default
(pass) getPreviewUrl > returns an https preview link on the environment that has a web app
(pass) getPreviewUrl > returns null (never throws) on an environment with no web app

::endgroup::

::group::tests/unit/bulletin/uploadManifest.test.ts:
(pass) upload manifest resume behavior > returns stale manifest when fingerprint does not match [3.00ms]
(pass) upload manifest resume behavior > deduplicates completed blocks by index [1.00ms]

::endgroup::

::group::tests/unit/bulletin/uploadProfiling.test.ts:
(pass) upload profiler > writes schema-complete profile report with peak aggregation [24.00ms]
(pass) upload profiler > default profile path is deterministic for a given fingerprint

::endgroup::

::group::tests/unit/bulletin/bulletinCliHelp.test.ts:
(pass) root help lists bulletin command [3.00ms]
(pass) bulletin help shows commands and description [2.00ms]
(pass) bulletin upload help shows all options [2.00ms]
(pass) bulletin upload help shows default values [2.00ms]
(pass) bulletin authorize help shows all options [3.00ms]
(pass) bulletin authorize help shows default values [3.00ms]
(pass) bulletin history help shows options [3.00ms]
(pass) bulletin history:remove help shows usage [3.00ms]
(pass) bulletin history:clear help shows description [3.00ms]
(pass) bulletin help command shows bulletin help [4.00ms]
(pass) bulletin help upload shows upload help [3.00ms]
(pass) bulletin help authorize shows authorize help [3.00ms]
(pass) bulletin status help shows all options [2.00ms]
(pass) bulletin help status shows status help [2.00ms]
(pass) bulletin list alias works [2.00ms]
(pass) bulletin verify help shows usage [2.00ms]
(pass) bulletin help verify shows verify help [2.00ms]

::endgroup::

::group::tests/unit/utils/validation.test.ts:
(pass) normaliseLabel > lowercases, trims, and strips a single trailing .dot [1.00ms]
(pass) normaliseLabel > strips the given TLD suffix rather than assuming .dot
(pass) isSecondLevelDotName > distinguishes a second-level name from a subdomain under the given TLD [1.00ms]
(pass) isCanonicalLabel > accepts lowercase letters, digits and internal hyphens
(pass) isCanonicalLabel > rejects dots, uppercase, spaces and other characters
(pass) isCanonicalLabel > rejects leading or trailing hyphens, empty and overlong labels
(pass) isSecondLevelDotName > accepts a single label, with or without the .dot suffix
(pass) isSecondLevelDotName > rejects subdomains
(pass) validateCanonicalLabel > throws for a name containing a dot, naming the role
(pass) validateCanonicalLabel > does not throw for a canonical label
(pass) countTrailingDigits > returns 0 for a label with no trailing digits
(pass) countTrailingDigits > returns the digit run length for a label with trailing digits
(pass) countTrailingDigits > does not count interior digits
(pass) stripTrailingDigits > returns the label unchanged when there are no trailing digits
(pass) stripTrailingDigits > strips the trailing digit run
(pass) validateDomainLabel digit-suffix rule > accepts labels with no trailing digits
(pass) validateDomainLabel digit-suffix rule > accepts labels with exactly two trailing digits
(pass) validateDomainLabel digit-suffix rule > rejects labels with exactly one trailing digit
(pass) validateDomainLabel digit-suffix rule > rejects labels with three or more trailing digits [1.00ms]
(pass) validateDomainLabel digit-suffix rule > rejects labels shorter than three characters
(pass) validateDomainLabel digit-suffix rule > rejects labels with uppercase characters
(pass) validateDomainLabel digit-suffix rule > rejects labels with leading or trailing hyphen
(pass) validateGovernanceLabel stem-length rule > accepts stems of five characters or fewer
(pass) validateGovernanceLabel stem-length rule > rejects stems longer than five characters
(pass) validateGovernanceLabel stem-length rule > measures the stem with trailing digits stripped
(pass) validateGovernanceLabel stem-length rule > does not apply the PopRules digit-suffix rule
(pass) validateGovernanceLabel is independent of the PopRules digit-suffix rule > accepts ONE trailing digit, which PopRules rejects outright
(pass) validateGovernanceLabel is independent of the PopRules digit-suffix rule > accepts THREE OR MORE trailing digits, which PopRules also rejects
(pass) validateGovernanceLabel is independent of the PopRules digit-suffix rule > accepts zero trailing digits
(pass) validateGovernanceLabel is independent of the PopRules digit-suffix rule > accepts exactly two trailing digits
(pass) validateGovernanceLabel is independent of the PopRules digit-suffix rule > the NORMAL path still enforces 0-or-2 trailing digits
(pass) validateGovernanceLabel canonical-label rules > rejects uppercase characters
(pass) validateGovernanceLabel canonical-label rules > rejects labels containing a dot
(pass) validateGovernanceLabel canonical-label rules > rejects leading or trailing hyphen [1.00ms]
(pass) validateGovernanceLabel canonical-label rules > rejects labels shorter than three characters

::endgroup::

::group::tests/unit/utils/contractInteractions.test.ts:
(pass) deriveDomainNode > matches namehashUnder(tldNode, labelhash) [2.00ms]
(pass) deriveDomainNode > different TLDs yield different nodes for the same label [1.00ms]
(pass) deriveDomainTokenId > is uint256(node)
(pass) deriveDomainTokenId > known vector: getsome under .dot
(pass) isRevertFlag matches the EVM revert bit > flags=0n → false
(pass) isRevertFlag matches the EVM revert bit > flags=1n → true
(pass) isRevertFlag matches the EVM revert bit > flags=2n → false
(pass) isRevertFlag matches the EVM revert bit > flags=3n → true
(pass) buildRevertError > empty data returns the unmapped-origin hint
(pass) buildRevertError > known ABI selector decodes to the named error [2.00ms]
(pass) buildRevertError > unknown selector falls back to raw hex [1.00ms]
(pass) decodeContractRevertError > empty data includes operation context
(pass) decodeContractRevertError > non-empty data decodes against the ABI [1.00ms]

::endgroup::

::group::tests/unit/text/textJson.test.ts:
(pass) text view --help shows --json option [3.00ms]
(pass) text set --help shows --json option [1.00ms]
(pass) text set --json emits JSON error when both mnemonic and key-uri provided [4.00ms]

::endgroup::

::group::tests/unit/text/textHelp.test.ts:
(pass) text --help lists subcommands and auth options [3.00ms]
(pass) text view --help shows name and key arguments [1.00ms]
(pass) text set --help shows name, key, and value arguments [2.00ms]

::endgroup::

::group::tests/unit/account/accountHelp.test.ts:
(pass) account --help lists subcommands including is-mapped, is-whitelisted, whitelist [2.00ms]
(pass) account is-mapped --help shows address argument and --json [2.00ms]
(pass) account is-whitelisted --help shows address argument and --json [2.00ms]
(pass) account whitelist --help shows address argument, --remove, and --json [1.00ms]
(pass) account is alias works for is-mapped [2.00ms]
(pass) account iw alias works for is-whitelisted [2.00ms]

::endgroup::

::group::tests/unit/register/registrationManifest.test.ts:
(pass) registration manifest persistence > saves a record and reads it back by label [74.00ms]
(pass) registration manifest persistence > encrypts the secret at rest (never stored in plaintext) [62.00ms]
(pass) registration manifest persistence > decrypts the secret with the correct credential [137.00ms]
(pass) registration manifest persistence > rejects decryption with the wrong credential [124.00ms]
(pass) registration manifest persistence > lists records for the env + caller, newest commit first [134.00ms]
(pass) registration manifest persistence > isolates records by env and caller [137.00ms]
(pass) registration manifest persistence > deletes a record [60.00ms]
(pass) registration manifest persistence > returns empty when nothing is cached
(pass) registration manifest persistence > clear record selection scopes to a requested label [136.00ms]
(pass) registration manifest persistence > clear record selection errors when a requested label is missing [64.00ms]
(pass) resolveManifestCredential > prefers password, then mnemonic, then key URI
(pass) resolveManifestCredential > returns null when no credential is available
(pass) resolveManifestCredential > uses env mnemonic and key URI for registration cache encryption
(pass) TLD ingested from chain > resolveTldInfo reads the deployment TLD rather than assuming .dot [1.00ms]
(pass) TLD ingested from chain > retries a transient read failure before resolving [302.00ms]
(pass) TLD ingested from chain > the immutable TLD is cached across calls
(pass) TLD ingested from chain > does not share the cache between clients that share a controller address
(pass) TLD ingested from chain > computeDomainTokenId derives the id under the chain TLD [1.00ms]
(pass) TLD ingested from chain > formatDomainName uses the deployment TLD suffix
(pass) ensureDomainNotRegistered enforces the controller predicate > passes when available(label) is true, checking available not ownerOf
(pass) ensureDomainNotRegistered enforces the controller predicate > throws with the real TLD suffix when available(label) is false [1.00ms]

::endgroup::

::group::tests/unit/register/registerHelp.test.ts:
(pass) root help lists register command [4.00ms]
(pass) register help shows subcommands [3.00ms]
(pass) register domain help shows options [3.00ms]
(pass) register subname help shows options [4.00ms]
(pass) register domain parses reverse flag [3.00ms]
(pass) register domain parses governance flag [2.00ms]
(pass) register domain parses owner option [5.00ms]
(pass) register domain parses transfer with destination [3.00ms]
(pass) register domain parses account option [2.00ms]
(pass) register domain parses keystore-path option [3.00ms]
(pass) register domain parses password option [2.00ms]
(pass) register domain parses mnemonic option [3.00ms]
(pass) register domain parses key-uri option [2.00ms]
(pass) register domain parses commitment-buffer option [3.00ms]
(pass) register domain parses commitment-buffer alias --cb [2.00ms]
(pass) register subname parses name and parent [4.00ms]
(pass) register subname parses owner option [2.00ms]
(pass) getCommitmentBufferSeconds defaults to 6 when env is not set
(pass) getCommitmentBufferSeconds reads from DOTNS_COMMITMENT_BUFFER env variable [1.00ms]
(pass) COMMITMENT_POLL_INTERVAL_MS is 2000
(pass) COMMITMENT_POLL_TIMEOUT_MS is 30000

::endgroup::

::group::tests/unit/register/registerJson.test.ts:
(pass) register domain --help shows --json option [3.00ms]
(pass) register subname --help shows --json option [3.00ms]
(pass) register domain --json emits JSON error when --transfer without --to [4.00ms]

::endgroup::

::group::tests/unit/register/registerOwnerConflicts.test.ts:
(pass) register domain rejects --owner with --transfer [5.00ms]
(pass) register domain rejects --owner with --reverse [3.00ms]
(pass) register domain rejects --owner with --governance [3.00ms]

::endgroup::

::group::tests/unit/cli/dotliViewUrls.test.ts:
(pass) paseo-v2 emits only its paseo.li gateway [1.00ms]
(pass) devnet emits only its dev-dot.li gateway
(pass) previewnet emits no dot.li gateway
(pass) passes the label through unchanged, so the TLD is never duplicated

::endgroup::

::group::tests/unit/cli/authOptions.test.ts:
(pass) getAuthOptions resolves a global --env given before a two-level-nested command [1.00ms]
(pass) getAuthOptions lets a command-level --env override the global one
(pass) getAuthOptions resolves the --network alias from the program root

::endgroup::

::group::tests/unit/cli/qrSigner.test.ts:
⚠ The QR mobile-wallet signer is experimental and still in development; expect rough edges.
(pass) createQrSigner > throws a clear error when no global WebSocket is available [1.00ms]
⚠ The QR mobile-wallet signer is experimental and still in development; expect rough edges.
Approve the signing allowance on your phone to continue.
(pass) createQrSigner > returns the SS58 origin derived from the paired signer's public key [3.00ms]

::endgroup::

::group::tests/unit/cli/transfer.test.ts:
(pass) resolveTransferRecipient > returns a raw EVM address in checksummed form without touching the chain
(pass) resolveTransferRecipient > rejects input that is neither an EVM address, SS58 address, nor domain name [1.00ms]

::endgroup::

::group::tests/unit/cli/signerKind.test.ts:
(pass) resolveSignerKind > defaults to keystore
(pass) resolveSignerKind > reads DOTNS_SIGNER=qr
(pass) resolveSignerKind > an explicit flag overrides the env var
(pass) resolveSignerKind > an unknown value falls back to keystore
(pass) resolveQrAppId > defaults to the unified product id
(pass) resolveQrAppId > flag beats env beats default
(pass) resolveQrPeopleEndpoints > defaults to the paseo stage
(pass) resolveQrPeopleEndpoints > resolves named stages
(pass) resolveQrPeopleEndpoints > treats a non-stage value as a comma-separated wss list
(pass) resolveQrPeopleEndpoints > rejects a non-wss URL
(pass) resolveQrPeopleEndpoints > rejects an empty/blank value [1.00ms]
(pass) resolveQrPeopleEndpoints > rejects a wss URL with embedded credentials
(pass) resolveQrPeopleEndpoints > flag beats env beats default
(pass) assertSignerOptions > keystore signer allows local-account flags
(pass) assertSignerOptions > qr signer with no local flags is allowed
(pass) assertSignerOptions > qr signer rejects a local-account flag
(pass) assertSignerOptions > qr signer lists every conflicting flag
(pass) assertSignerOptions > qr from env is also guarded
(pass) assertSignerOptions > qr signer rejects a keystore secret supplied via env

::endgroup::

::group::tests/unit/cli/bulletinRpc.test.ts:
(pass) paseo-v2 default resolves to the existing bulletin RPC [1.00ms]
(pass) explicit argument wins over env var and active env
(pass) env var wins over active env config when no explicit argument
(pass) falls back to active env's bulletin RPC
(pass) throws when nothing is configured (synthetic case)
(pass) bulletin cache Asset Hub RPC uses merged CLI rpc before DOTNS_RPC
(pass) bulletin cache Asset Hub RPC uses selected environment when no rpc override exists
(pass) bulletin cache rejects custom Bulletin env override without matching target
(pass) bulletin cache accepts custom Bulletin override with explicit environment
(pass) bulletin cache custom Bulletin with DOTNS_ENV ignores stale DOTNS_RPC
(pass) bulletin cache accepts custom Bulletin override with explicit Asset Hub RPC

::endgroup::

::group::tests/unit/cli/paseoCreate3Addresses.test.ts:
(pass) paseo-v2 uses the canonical 420420417 deployment address book
(pass) previewnet shares the same canonical address book as paseo-v2
(pass) devnet keeps its own distinct deployment, not the shared book

::endgroup::

::group::tests/unit/cli/environment.test.ts:
(pass) defaults to paseo-v2
(pass) accepts friendly paseo-v2 aliases [1.00ms]
(pass) DOTNS_ENV selects rpc and contract set
(pass) --env takes precedence over DOTNS_ENV while --rpc only overrides endpoint
(pass) printCommandHeader emits one contextual line with version, action, target and network

::endgroup::

 305 pass
 0 fail
 866 expect() calls
Ran 305 tests across 36 files. [4.63s]

bun install had injected the papi descriptors file: dependency into packages/cli/package.json and it rode into the previous commit; the committed lockfile does not record it, so CI's frozen install failed. Restores both files to main plus the 0.8.5 version bump only.

- drop issue references from code comments - isolate the default-credential test behind DOTNS_KEYSTORE_PATH - carry the last claim error on LabelStoreSyncResult and include it in the store-sync warning - only print the step success line when the store actually synced

re-gius

LGTM

filip-parity requested a review from waytwotall as a code owner September 2, 2026 15:15

github-actions Bot added pkg: cli type: test dependencies labels Sep 2, 2026

filip-parity requested review from corey-hathaway, filvecchiato and sphamjoli September 2, 2026 15:15

filip-parity added 2 commits September 2, 2026 18:21

chore: sync bun.lock with the cli version

00a1413

filip-parity requested a review from re-gius September 2, 2026 15:40

re-gius reviewed Sep 2, 2026

View reviewed changes

filip-parity requested a review from re-gius September 3, 2026 09:15

re-gius approved these changes Sep 3, 2026

View reviewed changes

filip-parity merged commit ad87dae into main Sep 3, 2026
21 checks passed

filip-parity deleted the fix/register-default-account-ux branch September 3, 2026 11:05

Navigation Menu

Uh oh!

fix(cli): register works with the implicit dev account and survives store-sync failures - #279

fix(cli): register works with the implicit dev account and survives store-sync failures#279
filip-parity merged 4 commits into
mainfrom
fix/register-default-account-ux

filip-parity commented Sep 2, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

re-gius left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

filip-parity commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Fixes

Testing

Uh oh!

github-actions Bot commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

re-gius left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

filip-parity commented Sep 2, 2026 •

edited

Loading

github-actions Bot commented Sep 2, 2026 •

edited

Loading