Repository navigation
Keep Intel Macs off a source build of cryptography - #79
Merged
Merged
Conversation
The Intel build still demanded macOS 15 after the Homebrew Python was removed, and the file setting it was still libcrypto.3.dylib. The cause is one version boundary: cryptography publishes macOS wheels for arm64 only from 49.0.0 on, so Intel had nothing to install and compiled it against the runner's OpenSSL - Homebrew's, preinstalled on GitHub's images - which PyInstaller then bundled. 48.0.0 is the last release with a universal2 wheel, and it targets 10.9. Constrained by marker so only darwin x86_64 is held back; the lock now carries 48.0.1 for that platform and 50.0.0 everywhere else. Verified here only that the lock resolves, installs and passes the suite - this machine is arm64, so it takes the 50.0.0 branch. The Intel path is CI's to prove.
saamdotexe
pushed a commit
to saamdotexe/OpenTagViewer
that referenced
this pull request
Oct 22, 2026
…graphy-wheel Keep Intel Macs off a source build of cryptography
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #78. That removed Homebrew's Python — file count in the bundle dropped from 352 to 239 — but the Intel build still demanded macOS 15, still set by
libcrypto.3.dylib.Cause
cryptographypublishes macOS wheels for arm64 only from 49.0.0 onward. 48.0.0 is the last release with auniversal2wheel, and that one targets macOS 10.9.So on Intel there was nothing to install and uv built it from source — 94 seconds of it in the log — linking against the runner's OpenSSL, which is Homebrew's and preinstalled on GitHub's macOS images. PyInstaller bundled that dylib, and its minimum macOS is baked in at Homebrew's build time.
arm64 never hit this: it has a wheel, its bundle contains no
libcryptoat all, and its minimum is 12.0 set by protobuf.Fix
A marker-scoped constraint, so only Intel macOS is held back and every other platform keeps the current release:
The lock now carries 48.0.1 with
macosx_10_9_universal2wheels and 50.0.0 with the arm64 ones.Verified
Lock resolves,
uv sync --frozeninstalls, 384 tests pass. This machine is arm64, so it takes the 50.0.0 branch — the Intel path can only be proved by CI. Run the workflow manually withexporter-v1.1.0after merging.Summary written by Claude Code.