Repository navigation
Say exporter-v where the release files still said macos-exporter-v - #70
Merged
Merged
Conversation
Rule 9 and release_version.py both make exporter-v the tag to use, with macos-exporter-v still resolving because published tags keep their names. Two files said otherwise, and they are the two someone reads at release time: version.py's docstring, and the usage example in the script itself. Also scopes CONTRIBUTING's Mac section, which opened by saying that testing an export means a real Mac. That was true of the route it describes and is no longer true of exporting. Left alone deliberately: every startsWith and also_accepts matching the old prefix, and the tests that use real published tags to cover it.
parawanderer
temporarily deployed
to
Android Build
August 15, 2026 18:53 — with
GitHub Actions
Inactive
parawanderer
temporarily deployed
to
Android Build
August 15, 2026 18:53 — with
GitHub Actions
Inactive
saamdotexe
pushed a commit
to saamdotexe/OpenTagViewer
that referenced
this pull request
Oct 22, 2026
…g-spelling Say exporter-v where the release files still said macos-exporter-v
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule 9 and
release_version.pyboth makeexporter-vthe tag to use;macos-exporter-vstill resolves for tags already published. Two files named the old spelling as the current one:python/exporter/version.py— docstringscripts/release_version.py— the usage example someone copiesAlso scoped CONTRIBUTING's "Running the export wizard on a Mac", which opened by saying testing an export means a real Mac. True of that route, not of exporting.
Every
startsWith/also_acceptsmatching the old prefix is untouched, as are the tests covering it.Checked:
exporter-v1.1.0andmacos-exporter-v1.1.0both resolve to1.1.0;scripts/test/passes (100).Summary written by Claude Code.