Feat/101 refresh homepage#102
Conversation
✅ Deploy Preview for rubycon ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request transitions the website to a post-event state by replacing ticket-related calls to action with links to session recordings and updating the hero section. Several issues were identified: the Gemfile.lock contains unexpected downgrades of core dependencies and Bundler, likely due to an outdated development environment. Additionally, the site version in _config.yml was not incremented as required by the repository style guide. Finally, multiple instances of hardcoded URLs for session recordings should be replaced with the newly defined site.event.rubyevents_url variable to ensure consistency and maintainability.
| google-protobuf (4.31.1-x86_64-linux-gnu) | ||
| bigdecimal | ||
| rake (>= 13) | ||
| google-protobuf (3.25.8) |
There was a problem hiding this comment.
Several core dependencies have been downgraded to significantly older versions (e.g., google-protobuf from 4.x to 3.x, sass-embedded from 1.90 to 1.69). Additionally, the Bundler version (line 126) has been downgraded from 2.7.1 to 2.3.24. This suggests the lockfile was updated using an outdated development environment, which could lead to compatibility issues or build failures in CI. Please verify your environment and restore the intended versions.
| tickets_url: "https://ti.to/rubycon/rubycon-2026/" | ||
| # sold_out_banner: ⏳ Early Bird tickets almost sold out! | ||
| # Post-event destination for session recordings | ||
| rubyevents_url: "https://www.rubyevents.org/events/rubycon-2026/talks" |
There was a problem hiding this comment.
The site_version in _config.yml was not incremented for these changes. According to the repository style guide, the version should be updated with semantic versioning for each set of changes.
References
- Whenever you do a change to the file, please update the version: field in rubycon.it/_config.yml (with semantic versioning) and CHANGELOG.md. (link)
| <div class="w-[318px] min-h-[88px] flex flex-col items-center gap-4 mx-auto"> | ||
| <a href="{{ site.event.tickets_url }}" class="cta-banner__action inline-flex items-center justify-center"> | ||
| Get your ticket now | ||
| <a href="https://www.rubyevents.org/talks/welcome-to-rubycon" target="_blank" rel="noopener" class="cta-banner__action inline-flex items-center justify-center"> |
There was a problem hiding this comment.
The URL for session recordings is hardcoded. It is recommended to use the site.event.rubyevents_url variable defined in _config.yml to maintain a single source of truth. Note that the hardcoded URL points to a specific talk, whereas the config variable points to the full list of talks, which better matches the 'Watch the sessions' label.
| <a href="https://www.rubyevents.org/talks/welcome-to-rubycon" target="_blank" rel="noopener" class="cta-banner__action inline-flex items-center justify-center"> | |
| <a href="{{ site.event.rubyevents_url }}" target="_blank" rel="noopener" class="cta-banner__action inline-flex items-center justify-center"> |
| <a href="#about" class="inline-block border border-[#fcf7e8]/40 text-[#fcf7e8] px-10 py-4 rounded-none transition-all duration-300 text-center" style="font-family: 'Noto Serif', serif; font-weight: 500; font-size: 20px; line-height: 20px; letter-spacing: 0;"> | ||
| Learn more | ||
| </a> | ||
| <a href="https://www.rubyevents.org/talks/welcome-to-rubycon" target="_blank" rel="noopener" class="inline-block bg-white/10 hover:bg-white/20 border border-white/30 text-white px-8 py-4 rounded-none transition-all duration-300">Watch the sessions</a> |
There was a problem hiding this comment.
The URL for session recordings is hardcoded. Please use the site.event.rubyevents_url variable from _config.yml for consistency.
<a href="{{ site.event.rubyevents_url }}" target="_blank" rel="noopener" class="inline-block bg-white/10 hover:bg-white/20 border border-white/30 text-white px-8 py-4 rounded-none transition-all duration-300">Watch the sessions</a>
| <div class="w-[318px] min-h-[88px] flex flex-col items-center gap-4 mx-auto"> | ||
| <a href="{{ site.event.tickets_url }}" class="inline-flex items-center justify-center" style="box-sizing: border-box; width: 254px; height: 52px; padding: 16px 32px; border: 1px solid #FCF7E8; color: #FCF7E8; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 20px; line-height: 20px; letter-spacing: 0; text-transform: none; vertical-align: middle; white-space: nowrap;"> | ||
| Get your ticket now | ||
| <a href="https://www.rubyevents.org/talks/welcome-to-rubycon" target="_blank" rel="noopener" class="inline-flex items-center justify-center" style="box-sizing: border-box; width: 254px; height: 52px; padding: 16px 32px; border: 1px solid #FCF7E8; color: #FCF7E8; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 20px; line-height: 20px; letter-spacing: 0; text-transform: none; vertical-align: middle; white-space: nowrap;"> |
There was a problem hiding this comment.
The URL for session recordings is hardcoded. Please use the site.event.rubyevents_url variable from _config.yml for consistency.
| <a href="https://www.rubyevents.org/talks/welcome-to-rubycon" target="_blank" rel="noopener" class="inline-flex items-center justify-center" style="box-sizing: border-box; width: 254px; height: 52px; padding: 16px 32px; border: 1px solid #FCF7E8; color: #FCF7E8; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 20px; line-height: 20px; letter-spacing: 0; text-transform: none; vertical-align: middle; white-space: nowrap;"> | |
| <a href="{{ site.event.rubyevents_url }}" target="_blank" rel="noopener" class="inline-flex items-center justify-center" style="box-sizing: border-box; width: 254px; height: 52px; padding: 16px 32px; border: 1px solid #FCF7E8; color: #FCF7E8; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 20px; line-height: 20px; letter-spacing: 0; text-transform: none; vertical-align: middle; white-space: nowrap;"> |
1 participant
Close #101